Skip to content

fix: add recommendations when no issues are reported #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix: add recommendations when no issues are reported #256

merged 1 commit into from
Jan 10, 2024

Conversation

@ruromero
Copy link
Collaborator

@ruromero ruromero commented Jan 10, 2024

Fix TC-847

@ruromero ruromero requested a review from zvigrinberg January 10, 2024 08:53
zvigrinberg
zvigrinberg approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@zvigrinberg zvigrinberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Approved, it was also tested locally and it solved the original issue in the Intelli-J RHDA plugin.
Thanks!.

@ruromero ruromero merged commit c99441f into guacsec:main Jan 10, 2024
@ruromero ruromero deleted the tc-847 branch January 10, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zvigrinberg zvigrinberg zvigrinberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ruromero @zvigrinberg