Merge pull request #256 from ruromero/tc-847

fix: add recommendations when no issues are reported

Author: ruromero

src/main/java/com/redhat/exhort/integration/providers/ProviderResponseHandler.java

@@ -215,6 +215,9 @@ public ProviderReport buildReport(
       return new ProviderReport().status(response.status()).sources(Collections.emptyMap());
     }
     var sourcesIssues = splitIssuesBySource(response.issues());
+    if (sourcesIssues.isEmpty() && !tcResponse.recommendations().isEmpty()) {
+      sourcesIssues.put(getProviderName(), Collections.emptyMap());
+    }
     Map<String, Source> reports = new HashMap<>();
     sourcesIssues
         .keySet()
@@ -227,7 +230,7 @@ public ProviderReport buildReport(
     return new ProviderReport().status(defaultOkStatus(getProviderName())).sources(reports);
   }
 
-  public Source buildReportForSource(
+  private Source buildReportForSource(
       Map<String, List<Issue>> issuesData,
       DependencyTree tree,
       String privateProviders,

src/test/java/com/redhat/exhort/integration/providers/ProviderResponseHandlerTest.java

@@ -285,6 +285,46 @@ public void testRecommendations() throws IOException {
     assertTrue(source.getDependencies().stream().noneMatch(d -> d.getRef().name().equals("ac")));
   }
 
+  @Test
+  public void testRecommendationsWithoutIssues() throws IOException {
+    PackageRef abRecommendation = new PackageRef("pkg:npm/ab@1-redhat-00001");
+    PackageRef acRecommendation = new PackageRef("pkg:npm/ac@1-redhat-00006");
+    Map<PackageRef, IndexedRecommendation> recommendations =
+        Map.of(
+            new PackageRef("pkg:npm/ab@1"),
+            new IndexedRecommendation(abRecommendation, Collections.emptyMap()),
+            acRecommendation, // recommend the same should be ignored
+            new IndexedRecommendation(acRecommendation, Collections.emptyMap()));
+
+    Map<String, List<Issue>> issues = Collections.emptyMap();
+
+    ProviderResponseHandler handler = new TestResponseHandler();
+
+    var report =
+        handler.buildReport(
+            new ProviderResponse(issues, null),
+            buildTree(),
+            null,
+            new TrustedContentResponse(recommendations, null));
+
+    assertNotNull(report);
+    assertNotNull(report.getSources());
+    Source source = report.getSources().get(TEST_PROVIDER);
+    assertNotNull(source);
+
+    assertEquals(1, source.getSummary().getRecommendations());
+    assertEquals(1, source.getDependencies().size());
+
+    assertTrue(
+        source.getDependencies().stream()
+            .anyMatch(
+                d ->
+                    d.getRef().name().equals("ab")
+                        && d.getRecommendation().equals(abRecommendation)));
+    assertTrue(source.getDependencies().stream().noneMatch(d -> d.getRef().name().equals("aa")));
+    assertTrue(source.getDependencies().stream().noneMatch(d -> d.getRef().name().equals("ac")));
+  }
+
   @Test
   public void testRemediations() throws IOException {
     PackageRef abRemediation = new PackageRef("pkg:npm/ab@1-redhat-00008");