lll: Advertise max line length instead of just reporting failure #4781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thank you for opening your first Pull Request ! |
|
|
ldez
added
enhancement
ldez
added
the
blocked: until next minor
Member
|
Hello, it's a good suggestion, I rephrased the message to be more explicit. |
Antonboom
approved these changes
Jun 1, 2024
ldez
removed
the
blocked: until next minor
ldez
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pardon if this has been discussed before, I couldn't find it in the issue/PR list.
As a user, I find it disorienting when tools inform me that I have made a mistake but do not offer any insights into how to resolve the issue.
In this case in particular, we have all the information, but then require the user to know the defaults and to traverse the config overrides.
It'd be nice to just provide this information. Impact to existing users should be minimal, including data transfer or storage of logs in CI, since teams who are already in compliance would not get the new log component, and teams who are not in compliance yet would get the message once and then be done.
Happy to circle back if there's prior art for how this information should be displayed.
Thanks!