Skip to content

lll: Advertise max line length instead of just reporting failure #4781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 9, 2024
Merged

lll: Advertise max line length instead of just reporting failure #4781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
415a738
lll: Advertise max line length instead of just reporting failure
blast-hardcheese May 31, 2024
a6b9d82
review: rephrase
ldez May 31, 2024
4cfa367
review: remove first letter uppercase
ldez Jun 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/golinters/lll/lll.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func getLLLIssuesForFile(filename string, maxLineLen int, tabSpaces string) ([]r
Filename: filename,
Line: lineNumber,
},
Text: fmt.Sprintf("line is %d characters", lineLen),
Text: fmt.Sprintf("the line is %d characters long, which exceeds the maximum of %d characters.", lineLen, maxLineLen),
FromLinter: linterName,
})
}
Expand Down
2 changes: 1 addition & 1 deletion test/run_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ func TestLineDirective(t *testing.T) {
},
configPath: "testdata/linedirective/lll.yml",
targetPath: "linedirective",
expected: "line is 57 characters (lll)",
expected: "the line is 57 characters long, which exceeds the maximum of 50 characters. (lll)",
},
{
desc: "misspell",
Expand Down