Skip to content

Fix context menu overflow & review tag margin #9231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2019
Merged

Fix context menu overflow & review tag margin #9231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cd876b
Fix context menu overflow
jolheiser Dec 2, 2019
516b2de
Add review tag CSS
jolheiser Dec 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion public/css/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ i.icon.centerlock{top:1.5em}
.lines-commit .ui.avatar.image{height:18px;width:18px}
.lines-code .bottom-line,.lines-commit .bottom-line,.lines-num .bottom-line{border-bottom:1px solid #eaecef}
.code-view{overflow:auto;overflow-x:auto;overflow-y:hidden}
.code-view.has-context-menu{overflow:visible;overflow-x:visible;overflow-y:visible}
.code-view :not(.fa):not(.octicon):not(.icon){font-size:12px;font-family:'SF Mono',Consolas,Menlo,'Liberation Mono',Monaco,'Lucida Console',monospace;line-height:20px}
.code-view table{width:100%}
.code-view .active{background:#fff866}
Expand Down Expand Up @@ -572,7 +573,8 @@ i.icon.centerlock{top:1.5em}
.repository.view.issue .comment-list .timeline-line:before{display:block;content:"";position:absolute;margin-top:12px;margin-bottom:14px;top:0;bottom:0;left:82px;width:2px;background-color:#f3f3f3;z-index:-1}
.repository.view.issue .comment-list .comment .avatar{width:3em}
.repository.view.issue .comment-list .comment .tag{color:#767676;margin-top:3px;padding:2px 5px;font-size:12px;border:1px solid rgba(0,0,0,.1);border-radius:3px}
.repository.view.issue .comment-list .comment .tag.pending{color:#000;background-color:#fffbb2;margin-left:5px}
.repository.view.issue .comment-list .comment .tag.review{margin-left:5px}
.repository.view.issue .comment-list .comment .tag.review.pending{color:#000;background-color:#fffbb2}
.repository.view.issue .comment-list .comment .actions .item{float:left}
.repository.view.issue .comment-list .comment .actions .item.context{float:none}
.repository.view.issue .comment-list .comment .actions .item.tag{margin-right:5px}
Expand Down
2 changes: 1 addition & 1 deletion templates/repo/diff/box.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
</h4>
<div class="ui attached unstackable table segment">
{{if ne $file.Type 4}}
<div class="file-body file-code code-view code-diff {{if $.IsSplitStyle}}code-diff-split{{else}}code-diff-unified{{end}}">
<div class="file-body file-code code-view has-context-menu code-diff {{if $.IsSplitStyle}}code-diff-split{{else}}code-diff-unified{{end}}">
<table>
<tbody>
{{if $isImage}}
Expand Down
4 changes: 2 additions & 2 deletions templates/repo/diff/comments.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@
<div class="ui right actions">
{{if and .Review}}
{{if eq .Review.Type 0}}
<div class="item tag pending">
<div class="item tag review pending">
{{$.root.i18n.Tr "repo.issues.review.pending"}}
</div>
{{else}}
<div class="item tag">
<div class="item tag review">
{{$.root.i18n.Tr "repo.issues.review.review"}}
</div>
{{end}}
Expand Down
6 changes: 6 additions & 0 deletions web_src/less/_base.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1092,6 +1092,12 @@ i.icon.centerlock {
overflow-x: auto;
overflow-y: hidden;

&.has-context-menu {
overflow: visible;
overflow-x: visible;
overflow-y: visible;
}

*:not(.fa):not(.octicon):not(.icon) {
font-size: 12px;
font-family: @monospaced-fonts, monospace;
Expand Down
8 changes: 5 additions & 3 deletions web_src/less/_repository.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,10 +737,12 @@
font-size: 12px;
border: 1px solid rgba(0, 0, 0, 0.1);
border-radius: 3px;
&.pending {
color: black;
background-color: #fffbb2;
&.review {
margin-left: 5px;
&.pending {
color: black;
background-color: #fffbb2;
}
}
}

Expand Down