Skip to content

Fix context menu overflow & review tag margin #9231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2019
Merged

Fix context menu overflow & review tag margin #9231

merged 2 commits into from
Dec 2, 2019

Conversation

@jolheiser
Copy link
Member

@jolheiser jolheiser commented Dec 2, 2019

Resolves #9161

context

Also applies a small CSS fix for Review tags.

Before
pending-before

After
pending

@jolheiser
Fix context menu overflow
8cd876b 
Signed-off-by: jolheiser <[email protected]>
@jolheiser
Add review tag CSS
516b2de 
Signed-off-by: jolheiser <[email protected]>
@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI labels Dec 2, 2019
@techknowlogick techknowlogick added this to the 1.11.0 milestone Dec 2, 2019
@codecov-io
Copy link

codecov-io commented Dec 2, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a00d720). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9231   +/-   ##
=========================================
  Coverage          ?   41.09%           
=========================================
  Files             ?      555           
  Lines             ?    72393           
  Branches          ?        0           
=========================================
  Hits              ?    29748           
  Misses            ?    38900           
  Partials          ?     3745

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a00d720...516b2de. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 2, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 2, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 2, 2019
@lafriks lafriks merged commit 51432eb into go-gitea:master Dec 2, 2019
@jolheiser jolheiser deleted the context_overflow branch December 3, 2019 15:24
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+3 more reviewers

@axifive axifive axifive approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@adelowo adelowo adelowo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug

Projects

None yet

Milestone

1.11.0

Development

Successfully merging this pull request may close these issues.

Pull request comment menu in GUI: wrong z-order

8 participants

@jolheiser @codecov-io @lafriks @axifive @mrsdizzie @adelowo @techknowlogick @GiteaBot