Skip to content

Conversation

@Gusted
Copy link
Contributor

@Gusted Gusted commented Nov 24, 2021

  • Use the provided doer instead of rel.Publisher. The code will also run on edited releases and deleted ones, which isn't necessary done by rel.Publisher.

- Use the provided `doer` instead of `rel.Publisher`. The code will also
run on edited releases and deleted ones, which isn't necessary done by
`rel.Publisher`.
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 25, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 25, 2021
@wxiaoguang wxiaoguang added this to the 1.16.0 milestone Nov 25, 2021
@wxiaoguang wxiaoguang merged commit 4b4997c into go-gitea:main Nov 25, 2021
@Gusted Gusted deleted the fix-webhook-doer branch November 25, 2021 13:53
@Gusted
Copy link
Contributor Author

Gusted commented Nov 25, 2021

@lunny @wxiaoguang Should this be a backport?

@zeripath
Copy link
Contributor

I think this could do with a backport yes.

Gusted pushed a commit to Gusted/gitea that referenced this pull request Nov 25, 2021
- Backport of go-gitea#17806
- Very nice comment so that the bots will be nice to me.
@6543 6543 added the backport/done All backports for this PR have been created label Nov 25, 2021
zeripath pushed a commit that referenced this pull request Nov 26, 2021
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
- Use the provided `doer` instead of `rel.Publisher`. The code will also
run on edited releases and deleted ones, which isn't necessary done by
`rel.Publisher`.

Co-authored-by: wxiaoguang <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants