Use correct user on releases (#17806)

Gusted · wxiaoguang · web-flow · commit 4b4997c73e63 · 2021-11-25T12:17:16.000+08:00
- Use the provided `doer` instead of `rel.Publisher`. The code will also
run on edited releases and deleted ones, which isn't necessary done by
`rel.Publisher`.

Co-authored-by: wxiaoguang &lt;wxiaoguang@gmail.com&gt;
diff --git a/modules/notification/webhook/webhook.go b/modules/notification/webhook/webhook.go
@@ -769,12 +769,12 @@ func sendReleaseHook(doer *user_model.User, rel *models.Release, action api.Hook
 		return
 	}
 
-	mode, _ := models.AccessLevel(rel.Publisher, rel.Repo)
+	mode, _ := models.AccessLevel(doer, rel.Repo)
 	if err := webhook_services.PrepareWebhooks(rel.Repo, webhook.HookEventRelease, &api.ReleasePayload{
 		Action:     action,
 		Release:    convert.ToRelease(rel),
 		Repository: convert.ToRepo(rel.Repo, mode),
-		Sender:     convert.ToUser(rel.Publisher, nil),
+		Sender:     convert.ToUser(doer, nil),
 	}); err != nil {
 		log.Error("PrepareWebhooks: %v", err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -769,12 +769,12 @@ func sendReleaseHook(doer user_model.User, rel models.Release, action api.Hook`
`769`	`769`	`return`
`770`	`770`	`}`
`771`	`771`
`772`		`- mode, _ := models.AccessLevel(rel.Publisher, rel.Repo)`
	`772`	`+ mode, _ := models.AccessLevel(doer, rel.Repo)`
`773`	`773`	`if err := webhook_services.PrepareWebhooks(rel.Repo, webhook.HookEventRelease, &api.ReleasePayload{`
`774`	`774`	`Action: action,`
`775`	`775`	`Release: convert.ToRelease(rel),`
`776`	`776`	`Repository: convert.ToRepo(rel.Repo, mode),`
`777`		`- Sender: convert.ToUser(rel.Publisher, nil),`
	`777`	`+ Sender: convert.ToUser(doer, nil),`
`778`	`778`	`}); err != nil {`
`779`	`779`	`log.Error("PrepareWebhooks: %v", err)`
`780`	`780`	`}`