chore: deprecate Etherscan V1 #11387
Open
+61
−259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
commented
Aug 28, 2025
Cargo.toml
Outdated
| @@ -407,7 +407,7 @@ idna_adapter = "=1.1.0" | |||
| # revm-inspectors = { git = "https://github.com/zerosnacks/revm-inspectors.git", rev = "74e215d" } | |||
|
|
|||
| ## foundry | |||
| # foundry-block-explorers = { git = "https://github.com/foundry-rs/block-explorers.git", rev = "e09cb89" } | |||
| foundry-block-explorers = { git = "https://github.com/foundry-rs/block-explorers.git", rev = "80ff600" } | |||
There was a problem hiding this comment.
Patch to be removed after new release of block-explorers
zerosnacks
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya,
onbjerg and
0xrusowsky
as code owners
onbjerg
previously approved these changes
Aug 28, 2025
|
Temporarily moved back to draft, found something I want to address in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes: #10913
Dependencies
chain, the URL is available directly and correctly inalloy-chains. block-explorers#109Related
Solution
Fully deprecates Etherscan version abstraction in favor of simpler V2 implementation as Etherscan has officially fully deprecated support for V1.
Manually tested against Etherscan, Blockscout and Sourcify without issue. No changes are actually expected considering the Etherscan V2 API is backwards compatible with Etherscan V1.
Breaking changes
The
etherscan_api_versionfield and setting are deprecatedPR Checklist