fix: avoid glueing with chain, the URL is available directly and correctly in alloy-chains.
#109
+9
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya,
onbjerg and
0xrusowsky
as code owners
mattsse
approved these changes
Aug 29, 2025
Comment on lines
-197
to
-199
| if self.chain_id.is_some() && !self.url_contains_chainid() { | ||
| post_query.insert("chainid", self.chain_id.unwrap()); | ||
| } |
There was a problem hiding this comment.
it did and it was functional but this is no longer necessary as we now consistently use the V2 URLs
… instead - note the inclusion of chainid parameter in returned url
zerosnacks
merged commit 7fc6e27
into
zerosnacks/drop-etherscan-v1-support
8 checks passed
This was referenced Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #101
also avoids any unnecessary insertions of
chainidas query parameter for other verifiers (though they were tolerant of it)