-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix(firebaseai): Added token details parsing for Dev API #17609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `thoughtsTokenCount` to `_parseUsageMetadata` in `packages/firebase_ai/firebase_ai/lib/src/api.dart` to align with the implementation in the developer API. - Added unit tests for `thoughtsTokenCount` parsing in `packages/firebase_ai/firebase_ai/test/api_test.dart`.
…etails` in the `_parseUsageMetadata` function.
258612b
to
917f432
Compare
cynthiajoan
approved these changes
Aug 8, 2025
natebosch
approved these changes
Aug 16, 2025
Lyokone
approved these changes
Aug 26, 2025
sybrands-place
pushed a commit
to sybrands-place/flutterfire
that referenced
this pull request
Aug 27, 2025
* main: (31 commits) making sure vertex instance will differentiate with location (firebase#17664) fix(firebaseai): Added token details parsing for Dev API (firebase#17609) feat(firebaseai): add thinking feature (firebase#17652) feat(firebaseai): Add app check limited use token (firebase#17645) fix(firebaseai): remove candidateCount from LiveGenerationConfig since the connection fails silently when it is set (firebase#17647) fix(firebaseai): Export `UnknownPart` (firebase#17655) fix(firebase_ai): Add `GroundingMetadata` parsing for Developer API (firebase#17657) fix(app_check, iOS): correctly parse `forceRefresh` argument using `boolValue` (firebase#17627) feat(firebaseai): imagen editing (firebase#17556) feat(firebaseai): add responseJsonSchema to GenerationConfig (firebase#17564) chore(firebaseai): fix error message test failure (firebase#17644) ci(apple): fix CI runners with explicit Xcode version (firebase#17634) chore(firebaseai): Minor fix for error message wording (firebase#17639) chore: fix warnings after latest flutter version (firebase#17640) Update CHANGELOG.md, put live api entry back for the official announcment (firebase#17635) fix(ci): ignore .gradle files in license check (firebase#17625) Remove `generateContent` call from count tokens page (firebase#17613) Update CHANGELOG.md (firebase#17621) Update CONTRIBUTING.md to add API change rule (firebase#17619) chore(release): publish packages (firebase#17618) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parsing for
promptTokensDetails
andcandidatesTokensDetails
when using the Gemini Developer API (Google AI). This PR updatesdeveloper/api.dart
(Google AI) to useparseUsageMetadata
fromapi.dart
(Vertex AI) since the implementations should be identical.Note: This is a follow-up to #17608.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos analyze-ci
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?