Skip to content

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Aug 7, 2025

This fixes an issue where the usageMetadata.thoughtsTokenCount is always null when using the Vertex AI backend.

  • Added thoughtsTokenCount to _parseUsageMetadata in packages/firebase_ai/firebase_ai/lib/src/api.dart to align with the implementation in the developer API.
  • Added unit tests for thoughtsTokenCount parsing in packages/firebase_ai/firebase_ai/test/api_test.dart.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

google-labs-jules bot and others added 3 commits August 7, 2025 20:11
- Added `thoughtsTokenCount` to `_parseUsageMetadata` in `packages/firebase_ai/firebase_ai/lib/src/api.dart` to align with the implementation in the developer API.
- Added unit tests for `thoughtsTokenCount` parsing in `packages/firebase_ai/firebase_ai/test/api_test.dart`.
@andrewheard andrewheard added the plugin: ai label issues for firebase_ai plugin label Aug 7, 2025
@andrewheard andrewheard marked this pull request as ready for review August 7, 2025 21:19
@andrewheard andrewheard requested a review from a-maurice August 8, 2025 15:46
@andrewheard andrewheard merged commit fe9ddd3 into main Aug 8, 2025
35 of 40 checks passed
@andrewheard andrewheard deleted the ah/add-thoughts-token-count branch August 8, 2025 18:13
gspencergoog pushed a commit to gspencergoog/flutterfire that referenced this pull request Aug 14, 2025
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: ai label issues for firebase_ai plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants