-
Notifications
You must be signed in to change notification settings - Fork 969
Merged first part of revamp_sign_in_methods #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
fedf1d4
Merged first part of revamp_sign_in_methods
wti806 8e8e760
used new sign in methods in test app
wti806 88d2e72
added second part of revamp sign in methods
wti806 f883ca5
added new APIs to Auth externs
wti806 a7dfadc
[AUTOMATED]: Prettier Code Styling
wti806 4958a45
fixed indentation
wti806 62e528a
Merge branch 'master' into revamp_sign_in_methods
wti806 3162782
updated auth externs for sign-in methods
wti806 86e1af5
Merge branch 'master' of https://github.com/firebase/firebase-js-sdk …
wti806 7a9cc93
Merge branch 'revamp_sign_in_methods' of https://github.com/wti806/fi…
wti806 fd43bba
changed format of type name is reference doc
wti806 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1045,6 +1045,9 @@ firebase.auth.Auth.prototype.useDeviceLanguage = function() {}; | |
* Creates a new user account associated with the specified email address and | ||
* password and returns any additional user info data or credentials. | ||
* | ||
* This method will be renamed to createUserWithEmailAndPassword replacing | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. encapsulate createUserWithEmailAndPassword with ticks ` here and below. |
||
* the existing method with the same name in the next major version change. | ||
* | ||
* On successful creation of the user account, this user will also be | ||
* signed in to your application. | ||
* | ||
|
@@ -1094,7 +1097,10 @@ firebase.auth.Auth.prototype.createUserAndRetrieveDataWithEmailAndPassword = fun | |
|
||
/** | ||
* Creates a new user account associated with the specified email address and | ||
* password. Will be depercated, replaced by | ||
* password. | ||
* | ||
* This method will be deprecated and will be updated to resolve with a | ||
* firebase.auth.UserCredential as is returned in | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. encapsulate firebase.auth.UserCredential with ticks ` |
||
* {@link firebase.auth.Auth#createUserAndRetrieveDataWithEmailAndPassword}. | ||
* | ||
* On successful creation of the user account, this user will also be | ||
|
@@ -1437,6 +1443,9 @@ firebase.auth.Auth.prototype.signInAndRetrieveDataWithCredential = function( | |
* Signs in a user asynchronously using a custom token and returns any | ||
* additional user info data or credentials. | ||
* | ||
* This method will be renamed to signInWithCustomToken replacing | ||
* the existing method with the same name in the next major version change. | ||
* | ||
* Custom tokens are used to integrate Firebase Auth with existing auth systems, | ||
* and must be generated by the auth backend. | ||
* | ||
|
@@ -1472,7 +1481,10 @@ firebase.auth.Auth.prototype.signInAndRetrieveDataWithCustomToken = function( | |
) {}; | ||
|
||
/** | ||
* Asynchronously signs in using a custom token. Will be depercated, replaced by | ||
* Asynchronously signs in using a custom token. | ||
* | ||
* This method will be deprecated and will be updated to resolve with a | ||
* firebase.auth.UserCredential as is returned in | ||
* {@link firebase.auth.Auth#signInAndRetrieveDataWithCustomToken}. | ||
* | ||
* Custom tokens are used to integrate Firebase Auth with existing auth systems, | ||
|
@@ -1510,6 +1522,9 @@ firebase.auth.Auth.prototype.signInWithCustomToken = function(token) {}; | |
* Asynchronously signs in using an email and password and returns any additional | ||
* user info data or credentials. | ||
* | ||
* This method will be renamed to signInWithEmailAndPassword replacing | ||
* the existing method with the same name in the next major version change. | ||
* | ||
* Fails with an error if the email address and password do not match. | ||
* | ||
* Note: The user's password is NOT the password used to access the user's email | ||
|
@@ -1557,8 +1572,10 @@ firebase.auth.Auth.prototype.signInAndRetrieveDataWithEmailAndPassword = functio | |
) {}; | ||
|
||
/** | ||
* Asynchronously signs in using an email and password. Will be depercated, | ||
* replaced by | ||
* Asynchronously signs in using an email and password. | ||
* | ||
* This method will be deprecated and will be updated to resolve with a | ||
* firebase.auth.UserCredential as is returned in | ||
* {@link firebase.auth.Auth#signInAndRetrieveDataWithEmailAndPassword}. | ||
* | ||
* Fails with an error if the email address and password do not match. | ||
|
@@ -1697,6 +1714,9 @@ firebase.auth.ConfirmationResult.prototype.confirm = function( | |
* Signs in a user anonymously and returns any additional user info data or | ||
* credentials. | ||
* | ||
* This method will be renamed to signInAnonymously replacing the existing | ||
* method with the same name in the next major version change. | ||
* | ||
* If there is already an anonymous user signed in, that user with | ||
* additional date will be returned; otherwise, a new anonymous user | ||
* identity will be created and returned. | ||
|
@@ -1726,8 +1746,11 @@ firebase.auth.ConfirmationResult.prototype.confirm = function( | |
firebase.auth.Auth.prototype.signInAnonymouslyAndRetrieveData = function() {}; | ||
|
||
/** | ||
* Asynchronously signs in as an anonymous user. Will be depercated, replaced | ||
* by {@link firebase.auth.Auth#signInAnonymouslyAndRetrieveData}. | ||
* Asynchronously signs in as an anonymous user. | ||
* | ||
* This method will be deprecated and will be updated to resolve with a | ||
* firebase.auth.UserCredential as is returned in | ||
* {@link firebase.auth.Auth#signInAnonymouslyAndRetrieveData}. | ||
* | ||
* If there is already an anonymous user signed in, that user will be returned; | ||
* otherwise, a new anonymous user identity will be created and returned. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add another paragraph.
This method will be renamed to
createUserWithEmailAndPassword
replacing the existing method with the same name in the next major version change.Do the same for the other 3.