Merged first part of revamp_sign_in_methods #344
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
Added email address in git config to pass the CLA check |
wti806
force-pushed
the
revamp_sign_in_methods
branch
from
813a774 to
fedf1d4
Compare
|
CLAs look good, thanks! |
|
Looks good, can you also add the changes to the test app? |
|
|
||
| /** | ||
| * Creates a new user account associated with the specified email address and | ||
| * password. Will be depercated, replaced by |
There was a problem hiding this comment.
This method will be deprecated and will be updated to resolve with a firebase.auth.UserCredential as is returned in {@link firebase.auth.Auth#createUserAndRetrieveDataWithEmailAndPassword}.
| ) {}; | ||
|
|
||
| /** | ||
| * Asynchronously signs in using a custom token. Will be depercated, replaced by |
There was a problem hiding this comment.
This method will be deprecated and will be updated to resolve with a firebase.auth.UserCredential as is returned in {@link firebase.auth.Auth#signInAndRetrieveDataWithCustomToken}.
| ) {}; | ||
|
|
||
| /** | ||
| * Asynchronously signs in using an email and password. Will be depercated, |
There was a problem hiding this comment.
This method will be deprecated and will be updated to resolve with a firebase.auth.UserCredential as is returned in {@link firebase.auth.Auth#signInAndRetrieveDataWithEmailAndPassword}.
| firebase.auth.Auth.prototype.signInAnonymouslyAndRetrieveData = function() {}; | ||
|
|
||
| /** | ||
| * Asynchronously signs in as an anonymous user. Will be depercated, replaced |
There was a problem hiding this comment.
This method will be deprecated and will be updated to resolve with a firebase.auth.UserCredential as is returned in {@link firebase.auth.Auth#signInAnonymouslyAndRetrieveData}.
| @@ -1043,7 +1043,59 @@ firebase.auth.Auth.prototype.useDeviceLanguage = function() {}; | |||
|
|
|||
| /** | |||
| * Creates a new user account associated with the specified email address and | |||
| * password. | |||
| * password and returns any additional user info data or credentials. | |||
| * | |||
There was a problem hiding this comment.
Add another paragraph.
This method will be renamed to createUserWithEmailAndPassword replacing the existing method with the same name in the next major version change.
Do the same for the other 3.
…into revamp_sign_in_methods
…rebase-js-sdk into revamp_sign_in_methods
| @@ -1045,6 +1045,9 @@ firebase.auth.Auth.prototype.useDeviceLanguage = function() {}; | |||
| * Creates a new user account associated with the specified email address and | |||
| * password and returns any additional user info data or credentials. | |||
| * | |||
| * This method will be renamed to createUserWithEmailAndPassword replacing | |||
There was a problem hiding this comment.
encapsulate createUserWithEmailAndPassword with ticks ` here and below.
| * password. | ||
| * | ||
| * This method will be deprecated and will be updated to resolve with a | ||
| * firebase.auth.UserCredential as is returned in |
There was a problem hiding this comment.
encapsulate firebase.auth.UserCredential with ticks `
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.