Part I - Implementation of Evaluate (percent condition) #686
+1,027
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add types for server template; implementation of evaluate and percent condition operator
Namyalg
changed the title
lahirumaramba
approved these changes
May 6, 2025
Namyalg
added a commit
that referenced
this pull request
May 10, 2025
Namyalg
added a commit
that referenced
this pull request
May 16, 2025
Namyalg
added a commit
that referenced
this pull request
May 20, 2025
Namyalg
added a commit
that referenced
this pull request
May 20, 2025
Namyalg
added a commit
that referenced
this pull request
May 20, 2025
Namyalg
added a commit
that referenced
this pull request
May 20, 2025
Namyalg
added a commit
that referenced
this pull request
May 20, 2025
Namyalg
added a commit
that referenced
this pull request
May 28, 2025
* chore: minor refactors and updates to comments, address review #686 (comment) --------- Co-authored-by: Pijush Chakraborty <[email protected]>
Namyalg
added a commit
that referenced
this pull request
Jul 14, 2025
* chore: minor refactors and updates to comments, address review #686 (comment) --------- Co-authored-by: Pijush Chakraborty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
server_template_types.goserver_templatecontains the logic that evaluates the template to return the config.condition_evaluatorcontains the implementation of the condition typeUser in Random Percentage, custom signals will be added subsequently.