chore: address review #686 (comment), update comments

Author: Namyalg

remoteconfig/condition_evaluator.go

@@ -148,11 +148,13 @@ func (ce *conditionEvaluator) evaluatePercentCondition(percentCondition *percent
 }
 
 func computeInstanceMicroPercentile(seed string, randomizationID string) uint32 {
-	seedPrefix := ""
+	var sb strings.Builder
 	if len(seed) > 0 {
-		seedPrefix = fmt.Sprintf("%s.", seed)
+		sb.WriteString(seed)
+		sb.WriteRune('.')
 	}
-	stringToHash := fmt.Sprintf("%s%s", seedPrefix, randomizationID)
+	sb.WriteString(randomizationID)
+	stringToHash := sb.String()
 
 	hash := sha256.New()
 	hash.Write([]byte(stringToHash))

remoteconfig/remoteconfig.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// Package remoteconfig allows clients to use Firebase Remote Config.
+// Package remoteconfig provides functions to fetch and evaluate a server-side Remote Config template.
 package remoteconfig
 
 import (
@@ -78,7 +78,7 @@ func newRcClient(client *internal.HTTPClient, conf *internal.RemoteConfigClientC
 	}
 }
 
-// GetServerTemplate Initializes a new ServerTemplate instance and fetches the server template.
+// GetServerTemplate initializes a new ServerTemplate instance and fetches the server template.
 func (c *rcClient) GetServerTemplate(ctx context.Context,
 	defaultConfig map[string]any) (*ServerTemplate, error) {
 	template, err := c.InitServerTemplate(defaultConfig, "")

remoteconfig/server_config.go

@@ -75,7 +75,7 @@ func (s *ServerConfig) GetInt(key string) int {
 // GetFloat returns the float value associated with the given key.
 //
 // If the parameter value cannot be parsed as a float64, or if the key is not found,
-// it returns the default numeric value (0).
+// it returns the default float value (0).
 func (s *ServerConfig) GetFloat(key string) float64 {
 	return s.getValue(key).asFloat()
 }
@@ -136,12 +136,12 @@ func (v *value) asInt() int {
 	return num
 }
 
-// asFloat returns the value as an integer.
+// asFloat returns the value as a float.
 func (v *value) asFloat() float64 {
 	if v.source == Static {
 		return defaultValueForNumber
 	}
-	num, err := strconv.ParseFloat(v.value, 64)
+	num, err := strconv.ParseFloat(v.value, doublePrecision)
 
 	if err != nil {
 		return defaultValueForNumber

remoteconfig/server_template.go

@@ -130,7 +130,7 @@ func (s *ServerTemplate) Evaluate(context map[string]any) (*ServerConfig, error)
 		config[key] = value{source: Default, value: inAppDefault}
 	}
 
-	usedConditions := s.cache.Load().getUsedConditions()
+	usedConditions := s.cache.Load().filterUsedConditions()
 	ce := conditionEvaluator{
 		conditions:        usedConditions,
 		evaluationContext: context,
@@ -164,7 +164,8 @@ func (s *ServerTemplate) Evaluate(context map[string]any) (*ServerConfig, error)
 	return newServerConfig(config), nil
 }
 
-func (s *serverTemplateData) getUsedConditions() []namedCondition {
+// filterUsedConditions identifies conditions that are referenced by parameters and returns them in order of decreasing priority.
+func (s *serverTemplateData) filterUsedConditions() []namedCondition {
 	usedConditionNames := make(map[string]struct{})
 	for _, parameter := range s.Parameters {
 		for name := range parameter.ConditionalValues {

remoteconfig/server_template_test.go

@@ -450,10 +450,10 @@ func TestGetUsedConditions(t *testing.T) {
 
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
-			used := tc.data.getUsedConditions()
+			used := tc.data.filterUsedConditions()
 
 			if len(used) != len(tc.expectedConditions) {
-				t.Fatalf("getUsedConditions() returned %d conditions, want %d", len(used), len(tc.expectedConditions))
+				t.Fatalf("filterUsedConditions() returned %d conditions, want %d", len(used), len(tc.expectedConditions))
 			}
 
 			for idx, ec := range tc.expectedConditions {