chore: Merging v4 branch into dev #370
Conversation
* chore: Added Actions-based release workflow * Set GOPATH * Fixed working directory for tests * Decrypting credentials into the testdata directory * Added preflight and post check scripts
…#335) According to the document https://developers.google.com/instance-id/reference/server, the endpoints should be: https://iid.googleapis.com/iid/v1:batchAdd https://iid.googleapis.com/iid/v1:batchRemove NOT: https://iid.googleapis.com/iid/v1/:batchAdd https://iid.googleapis.com/iid/v1/:batchRemove
Co-authored-by: Hiranya Jayathilaka <[email protected]>
* fix: Error handling revamp basic structure * Added more documentation and tests * Updated docs * Exhaustive unit tests; Updated integration test * Fixed some typos in comments * Renamed function in comment
* FCM error handling revamp * Updated unit tests
* Error handling revamp for Auth APIs * Minor code clean up
* New error handling scheme for token verification APIs * Make InvalidToken condition conjunctive
* Removed deprecated APIs from internal * Made HasSuccessStatus the default error checking function * Added unit test for error response handling
* Handling timeouts, connection and other network errors * Handling wrapped errors * Updated comment * Apply suggestions from code review Co-Authored-By: Lahiru Maramba <[email protected]> Co-authored-by: Lahiru Maramba <[email protected]>
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
* chore: Updated release flow for modules support * Fixed failing unit test * Removed GOPATH from release workflow
|
These important release notes didn’t make it into your published changes for the release. Could you fix that by hand, maybe? |
|
@cee-dub those comments were certainly included in the published released notes: https://firebase.google.com/support/release-notes/admin/go#version_400_-_16_june_2020 |
|
@hiranya911 ah, thank you. I was looking here https://github.com/firebase/firebase-admin-go/releases/tag/v4.0.0 |
|
@cee-dub Ah, I see what you mean. That section is a simple changelog generated off of git commit messages, and therefore PR descriptions usually get ignored. However, since this release contains some important changes, it might be useful to have that information on that page as well. I'll look into it. |
Contains modules support and other breaking API changes.
API CHANGE: Admin SDK has opted into Go modules. The package name now has the major version appended to it. Developers should use the new package name
firebase.google.com/go/v4when installing and importing the SDK.RELEASE NOTE: change(fcm): The
messaging.WebpushFcmOptionstype has been renamed tomessaging.WebpushFCMOptions.RELEASE NOTE: feat(fcm): Added new service-level error checking functions
IsThirdPartyAuthError(),IsQuotaExceeded(),IsSenderIDMismatch(),IsUnregistered()andIsUnavailable().RELEASE NOTE: feat: Added a new
errorutilspackage that provides functions for checking for platform-level error codes.RELEASE NOTE: feat(auth): Added new service-level error checking functions
IsIDTokenInvalid(),IsIDTokenExpired(),IsSessionCookieInvalid(),IsSessionCookieExpired()andIsCertificateFetchFailed(). These functions can be used in conjunction with the existing JWT verification APIs provided by the SDK.