RTDB error handling revamp #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahirumaramba
approved these changes
Mar 10, 2020
| if err == nil || err.Error() != want { | ||
| t.Errorf("GetOrdered() = %v; want = %v", err, want) | ||
| if result != nil || err == nil || err.Error() != want { | ||
| t.Fatalf("GetOrdered() = (%v, %v); want = (nil, %v)", result, err, want) |
There was a problem hiding this comment.
Just curious, why use Fatal here instead Error?
There was a problem hiding this comment.
Rest of the test should not run if this assertion fails.
hiranya911
added a commit
that referenced
this pull request
May 6, 2020
hiranya911
added a commit
that referenced
this pull request
Jun 11, 2020
* Renamed WebpushFcmOptions to WebpushFCMOptions (#334) * Added modules support; Added semantic import versioning (#336) * feat: New error handling APIs (#342) * fix: Error handling revamp basic structure * Added more documentation and tests * Updated docs * Exhaustive unit tests; Updated integration test * Fixed some typos in comments * Renamed function in comment * FCM error handling revamp (#343) * FCM error handling revamp * Updated unit tests * RTDB error handling revamp (#345) * Error handling revamp of Auth APIs (#348) * Error handling revamp for Auth APIs * Minor code clean up * Error handling support in the token verification APIs (#349) * New error handling scheme for token verification APIs * Make InvalidToken condition conjunctive * Removing deprecated HTTP and error handling utils (#350) * Removed deprecated APIs from internal * Made HasSuccessStatus the default error checking function * Added unit test for error response handling * Handling timeouts, connection and other network errors (#353) * Handling timeouts, connection and other network errors * Handling wrapped errors * Updated comment * Apply suggestions from code review * Removing old release workflow files * Removing an erroneous import * Fixed bad merge * Fixed failing test due to old dependency * chore: Updated release flow for modules support (#378) * chore: Updated release flow for modules support * Fixed failing unit test * Removed GOPATH from release workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal.