[Fizz] Should be considered complete inside onShellReady callback #33295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
|
Comparing: 4448b18...0c80167 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
gnoff
approved these changes
May 16, 2025
| }, | ||
| ); | ||
| }); | ||
| expect(output.result).toMatchInlineSnapshot(`"<div>hello world</div>"`); |
There was a problem hiding this comment.
could even move this into the onShellReady callback after the pipe. I think it will flush everything sync
github-actions bot
pushed a commit
that referenced
this pull request
May 16, 2025
…3295) We decremented `allPendingTasks` after invoking `onShellReady`. Which means that in that scope it wasn't considered fully complete. Since the pattern for flushing in Node.js is to start piping in `onShellReady` and that's how you can get sync behavior, this led us to think that we had more work left to do. For example we emitted the `writeShellTimeInstruction` in this scenario before. DiffTrain build for [c250b7d](c250b7d)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
May 17, 2025
…cebook#33295) We decremented `allPendingTasks` after invoking `onShellReady`. Which means that in that scope it wasn't considered fully complete. Since the pattern for flushing in Node.js is to start piping in `onShellReady` and that's how you can get sync behavior, this led us to think that we had more work left to do. For example we emitted the `writeShellTimeInstruction` in this scenario before. DiffTrain build for [c250b7d](facebook@c250b7d)
github-actions bot
pushed a commit
to addcx1developer/react
that referenced
this pull request
May 17, 2025
…cebook#33295) We decremented `allPendingTasks` after invoking `onShellReady`. Which means that in that scope it wasn't considered fully complete. Since the pattern for flushing in Node.js is to start piping in `onShellReady` and that's how you can get sync behavior, this led us to think that we had more work left to do. For example we emitted the `writeShellTimeInstruction` in this scenario before. DiffTrain build for [c250b7d](facebook@c250b7d)
github-actions bot
pushed a commit
to addcx1developer/react
that referenced
this pull request
May 17, 2025
…cebook#33295) We decremented `allPendingTasks` after invoking `onShellReady`. Which means that in that scope it wasn't considered fully complete. Since the pattern for flushing in Node.js is to start piping in `onShellReady` and that's how you can get sync behavior, this led us to think that we had more work left to do. For example we emitted the `writeShellTimeInstruction` in this scenario before. DiffTrain build for [c250b7d](facebook@c250b7d)
This was referenced May 19, 2025
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decremented
allPendingTasksafter invokingonShellReady. Which means that in that scope it wasn't considered fully complete.Since the pattern for flushing in Node.js is to start piping in
onShellReadyand that's how you can get sync behavior, this led us to think that we had more work left to do. For example we emitted thewriteShellTimeInstructionin this scenario before.