Skip to content

Commit 93e7559

Browse files
addcx1developeraddcx1developer
committed
[Fizz] Should be considered complete inside onShellReady callback (facebook#33295)
We decremented `allPendingTasks` after invoking `onShellReady`. Which means that in that scope it wasn't considered fully complete. Since the pattern for flushing in Node.js is to start piping in `onShellReady` and that's how you can get sync behavior, this led us to think that we had more work left to do. For example we emitted the `writeShellTimeInstruction` in this scenario before. DiffTrain build for [c250b7d](facebook@c250b7d)
1 parent ea9e061 commit 93e7559

File tree

52 files changed

+212264
-107616
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+212264
-107616
lines changed

‎compiled/eslint-plugin-react-hooks/index.js

Lines changed: 60705 additions & 0 deletions
Large diffs are not rendered by default.

‎compiled/facebook-www/JSXDEVRuntime-dev.classic.js

Lines changed: 87 additions & 498 deletions
Large diffs are not rendered by default.

‎compiled/facebook-www/JSXDEVRuntime-dev.modern.js

Lines changed: 87 additions & 498 deletions
Large diffs are not rendered by default.

‎compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
152bfe3769f87e29c8d68cb87fdb608d2483b7f1
1+
c250b7d980864be49facf2306f06455e7f9e305d

‎compiled/facebook-www/REVISION_TRANSFORMS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
152bfe3769f87e29c8d68cb87fdb608d2483b7f1
1+
c250b7d980864be49facf2306f06455e7f9e305d

0 commit comments

Comments
 (0)