Skip to content

fix: avoid race conditions when fetching background trace #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

fix: avoid race conditions when fetching background trace #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions front_end/entrypoints/main/MainImpl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,12 @@ export class MainImpl {
// would request and evaluate the Timeline panel dep tree, slowing down the UI's load.
const Timeline = await import('../../panels/timeline/timeline.js');
Timeline.TimelinePanel.LoadTimelineHandler.instance().handleQueryParam(value);
} else {
const panel = Root.Runtime.Runtime.queryParam('panel');
if (panel === 'timeline') {
// [RN] If panel is specified, we need Timeline to be ready and be subscribed to the events that will be emitted.
await import('../../panels/timeline/timeline.js');
}
}

// Initialize ARIAUtils.alert Element
Expand Down
3 changes: 1 addition & 2 deletions front_end/panels/timeline/TimelineController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,12 +203,11 @@ export class TimelineController implements Trace.TracingManager.TracingManagerCl
}

async rnPrepareForTraceCapturedInBackground(): Promise<void> {
await LiveMetrics.LiveMetrics.instance().disable();

if (this.tracingManager) {
this.tracingManager.rnPrepareForTraceCapturedInBackground(this);
}

await LiveMetrics.LiveMetrics.instance().disable();
this.client.loadingStarted();
await this.allSourcesFinished();
await LiveMetrics.LiveMetrics.instance().enable();
Expand Down
Loading