Skip to content

Conversation

@hoxyq
Copy link

@hoxyq hoxyq commented Sep 12, 2025

Summary

This includes 2 changes:

  1. If the panel query parameter is specified, which we are using to pre-open Timeline panel, we are going to static import it. If we will load it dynamically, there could be scenarios when it won't subscribe to ReactNativeApplication domain in time and will miss the required event to prepare for a incoming trace.
  2. Inside the TimelineController, update the TracingClient state synchronously first. This happens on start() event. if we don't do it, there are chances that tracingComplete() event could be handled first and it won't capture the trace.

Test plan

  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

@hoxyq hoxyq requested review from huntie and rubennorte September 12, 2025 16:35
@meta-cla meta-cla bot added the cla signed label Sep 12, 2025
@hoxyq hoxyq force-pushed the timeline/fix-race-conditions branch from bcca2d4 to abf5cab Compare September 15, 2025 16:05
@hoxyq hoxyq merged commit 8b84a77 into main Sep 15, 2025
5 checks passed
@hoxyq hoxyq deleted the timeline/fix-race-conditions branch September 15, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants