fix: avoid race conditions when fetching background trace #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This includes 2 changes:
panelquery parameter is specified, which we are using to pre-open Timeline panel, we are going to static import it. If we will load it dynamically, there could be scenarios when it won't subscribe toReactNativeApplicationdomain in time and will miss the required event to prepare for a incoming trace.start()event. if we don't do it, there are chances thattracingComplete()event could be handled first and it won't capture the trace.Test plan
Upstreaming plan
devtools-frontendrepo following the contribution guide for Meta employees OR contribution guide.