Skip to content

Conversation

nloureiro
Copy link
Contributor

This PR implements the design changes requested in issue #15718 for the community page "why get involved" section.

Changes

  • Remove background color from the section
  • Remove fixed height from the section
  • Make h2 4xl on desktop and remove mb-8 margin from parent h2 container

Implementation

  • Removed bg-[#ccfcff] and dark:bg-[#293233] background colors
  • Removed h-full and lg:h-[720px] fixed heights
  • Added lg:text-4xl to H2 component for desktop 4xl sizing
  • Removed mb-8 margin from h2 parent container

Fixes #15718

Generated with Claude Code

- Remove background color (bg-[#ccfcff] and dark:bg-[#293233])
- Remove fixed height (h-full and lg:h-[720px])  
- Make h2 4xl on desktop (lg:text-4xl)
- Remove mb-8 margin from h2 parent container

Fixes #15718

Co-authored-by: Joshua <[email protected]>
@nloureiro
Copy link
Contributor Author

@coderabbitai can you review

Copy link

netlify bot commented Jun 25, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 206d5a3
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/6876e1ca76b7a60009067333
😎 Deploy Preview https://deploy-preview-15724--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 43 (🔴 down 4 from production)
Accessibility: 94 (no change from production)
Best Practices: 92 (no change from production)
SEO: 99 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

coderabbitai bot commented Jun 25, 2025

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

@nloureiro I'll help you review this PR! Let me first gather information about the changes to provide you with a comprehensive review.


🏁 Script executed:

#!/bin/bash
# Get PR information including title, description, and changed files
gh pr view 15724 --repo ethereum/ethereum-org-website --json title,body,files,additions,deletions,changedFiles

# Get the detailed diff for the PR
gh pr diff 15724 --repo ethereum/ethereum-org-website

Length of output: 2127


@nloureiro I've reviewed PR #15724 and here's my analysis:

Overall Assessment: Looks Good!

This is a clean, focused PR that implements specific design changes for the community page's "why get involved" section. The changes are minimal and well-targeted.

Changes Analysis:

✅ Positive Changes:

  1. Flexible Height: Removing h-full and lg:h-[720px] makes the section more responsive and content-driven
  2. Clean Implementation: The changes exactly match the requirements in issue small design changes to the community page #15718
  3. Typography Enhancement: Adding lg:text-4xl to the H2 improves desktop readability
  4. Tighter Layout: Removing mb-8 creates better visual cohesion

⚠️ Considerations to Verify:

  1. Visual Hierarchy: Removing background colors (bg-[#ccfcff] and dark:bg-[#293233]) changes the section's visual prominence - ensure this doesn't affect the page's overall design balance
  2. Layout Testing: With fixed heights removed, verify the section still maintains proper proportions across different screen sizes and content lengths
  3. Accessibility: Test that the contrast remains sufficient without the background colors, especially in dark mode

Code Quality:

  • Clean diff: Only necessary changes made
  • Consistent with Tailwind patterns: Proper use of responsive classes
  • Maintainable: Clear, targeted modifications

Recommendation:

The implementation looks solid! I'd suggest testing the visual changes across different devices and content scenarios to ensure the layout remains cohesive without the fixed constraints.

Great work on keeping the changes focused and well-documented! 🚀

🐰💭 Thoughtful rabbit examining the clean, purposeful changes

@nloureiro nloureiro marked this pull request as ready for review June 26, 2025 09:07
@wackerow
Copy link
Member

image

@nloureiro This looks so much better... we probably want a bit more padding here though, assume this was overlooked by claude. I'll add some in and get this merged. If you disagree, please drop a note and we can always undo.

@wackerow
Copy link
Member

image

There, just a little extra space

@wackerow wackerow merged commit 0a256ec into dev Jul 15, 2025
6 of 7 checks passed
@wackerow wackerow deleted the claude/issue-15718-20250625_142515 branch July 15, 2025 23:19
This was referenced Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

small design changes to the community page
2 participants