-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix: update community page 'why get involved' section styling #15724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Remove background color (bg-[#ccfcff] and dark:bg-[#293233]) - Remove fixed height (h-full and lg:h-[720px]) - Make h2 4xl on desktop (lg:text-4xl) - Remove mb-8 margin from h2 parent container Fixes #15718 Co-authored-by: Joshua <[email protected]>
@coderabbitai can you review |
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain@nloureiro I'll help you review this PR! Let me first gather information about the changes to provide you with a comprehensive review. 🏁 Script executed:
Length of output: 2127 @nloureiro I've reviewed PR #15724 and here's my analysis: ✅ Overall Assessment: Looks Good!This is a clean, focused PR that implements specific design changes for the community page's "why get involved" section. The changes are minimal and well-targeted. Changes Analysis:✅ Positive Changes:
|
![]() @nloureiro This looks so much better... we probably want a bit more padding here though, assume this was overlooked by claude. I'll add some in and get this merged. If you disagree, please drop a note and we can always undo. |
This PR implements the design changes requested in issue #15718 for the community page "why get involved" section.
Changes
Implementation
bg-[#ccfcff]
anddark:bg-[#293233]
background colorsh-full
andlg:h-[720px]
fixed heightslg:text-4xl
to H2 component for desktop 4xl sizingmb-8
margin from h2 parent containerFixes #15718
Generated with Claude Code