-
Couldn't load subscription status.
- Fork 5.2k
[manual] Merge release/8.0-staging into release/8.0 #117636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…otnet#116609) * Move DNS EventSource tests to RemoteExecutor * Rethrow SkipTestException --------- Co-authored-by: Miha Zupan <[email protected]>
…ease/8.0-staging [automated] Merge branch 'release/8.0' => 'release/8.0-staging'
…et#116776) On Windows, we were incorrectly only checking for <letter>: and incorrectly determining that UNC and device paths were not absolute. This updates pal::is_path_rooted to match the managed Path.IsPathRooted and adds a pal::is_path_absolute with the logic of Path.IsPartiallyQualified This also adds an error message when we can't resolve hostfxr and tests for device paths.
Co-authored-by: Aaron R Robinson <[email protected]>
macOS Tahoe returns a compatibility version, 16, for macOS 26 unless it is built with Xcode 26's SDK. As we did with Big Sur, this maps the compatibility version 16 to 26. The intention is that we will be on the new SDK by the time macOS 27 rolls out. If not, then we will need to add another compatibility map, most likely. It does not appear that iOS, tvOS, or Catalyst return compatibility numbers, so they are excluded from doing any mapping. Co-authored-by: Kevin Jones <[email protected]>
…ence-packages build 20250519.2 (dotnet#116533) Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 8.0.0-alpha.1.25210.2 -> To Version 8.0.0-alpha.1.25269.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: David Cantú <[email protected]>
…dotnet#116551) * Update dependencies from https://github.com/dotnet/hotreload-utils build 20250611.1 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 8.0.0-alpha.0.25265.1 -> To Version 8.0.0-alpha.0.25311.1 * Update dependencies from https://github.com/dotnet/hotreload-utils build 20250630.2 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 8.0.0-alpha.0.25265.1 -> To Version 8.0.0-alpha.0.25330.2 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: David Cantú <[email protected]>
…ld 20250611.1 (dotnet#116572) Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData From Version 8.0.0-beta.25266.1 -> To Version 8.0.0-beta.25311.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: David Cantú <[email protected]>
* harden Ping_TimedOut_* tests * improve comments --------- Co-authored-by: antonfirsov <[email protected]> Co-authored-by: Anton Firszov <[email protected]>
…ease/8.0-staging [automated] Merge branch 'release/8.0' => 'release/8.0-staging'
…50520.1 (dotnet#116532) Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 8.0.0-prerelease.25255.2 -> To Version 8.0.0-prerelease.25270.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: David Cantú <[email protected]> Co-authored-by: Tarek Mahmoud Sayed <[email protected]>
…Exceeded_ThrowsInAllottedTime (dotnet#116439) * Extend remote execution timeout * Also move to Outerloop * L --------- Co-authored-by: Kevin Jones <[email protected]>
…116534) * Update dependencies from https://github.com/dotnet/arcade build 20250610.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.25263.4 -> To Version 8.0.0-beta.25310.3 * Bump the sdk version for workload testing --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: David Cantú <[email protected]> Co-authored-by: Tarek Mahmoud Sayed <[email protected]> Co-authored-by: Larry Ewing <[email protected]>
…ease/8.0-staging [automated] Merge branch 'release/8.0' => 'release/8.0-staging'
…t#112992) * Add BigInteger.Rotate* tests * Fix BigInteger.Rotate* * avoid stackalloc * Add comment * Fix the unsigned right shift operator of BigInteger (dotnet#112879) * Add tests for the shift operator of BigInteger * Fix the unsigned right shift operator of BigInteger * avoid stackalloc * external sign element --------- Co-authored-by: kzrnm <[email protected]> Co-authored-by: Tanner Gooding <[email protected]>
…et#109648) Co-authored-by: NicoAvanzDev <[email protected]> Co-authored-by: Adeel Mujahid <[email protected]> Co-authored-by: Stephen Toub <[email protected]> Co-authored-by: Michał Petryka <[email protected]>
…#115023)" (dotnet#117543) This reverts commit f9239a1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Merge release/8.0-staging into release/8.0, bringing in cross-platform I/O fixes, path qualification improvements, extensive test enhancements, and SDK/tooling version bumps.
- Introduce and apply
GetAllowedVectorCountto limit scatter/gather I/O (preadv/pwritev) on non-WASM platforms. - Replace
is_path_rootedwith the new, stricteris_path_fully_qualifiedchecks throughout corehost and hostpolicy code. - Expand BigInteger test coverage with new rotate operations and refactor shift tests for consistent behavior.
- Consolidate Ping timeout tests into a shared helper and add retry logic for unreachable networks.
- Bump SDK, tooling, and dependency versions across global.json, pipeline yaml, and Version.Details.xml.
Reviewed Changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/native/libs/System.Native/pal_io.c | Add GetAllowedVectorCount and use it in preadv/pwritev |
| src/native/external/zlib-intel/inflate.c | Change memory-error handling to early return |
| src/native/corehost/hostmisc/pal.windows.cpp | Add is_directory_separator and implement is_path_fully_qualified |
| src/native/corehost/hostmisc/pal.unix.cpp | Implement is_path_fully_qualified for Unix paths |
| src/native/corehost/hostpolicy/standalone/coreclr_resolver.cpp | Switch from is_path_rooted to is_path_fully_qualified |
| src/libraries/System.Runtime.Numerics/tests/BigInteger/op_rightshift.cs | Refactor to abstract op_rightshiftTestBase and inject opstring |
| src/libraries/System.Runtime.Numerics/tests/BigInteger/Rotate.cs | Add base and concrete rotate tests (RotateLeft/RotateRight) |
| src/libraries/System.Private.CoreLib/src/System/IO/RandomAccess.Unix.cs | Respect IOV limits and handle partial PWriteV writes |
| src/libraries/System.Net.Ping/tests/FunctionalTests/PingTest.cs | Consolidate timeout tests into Ping_TimedOut_Core helper |
| global.json, eng/Versions.props, eng/pipelines/**/*.yml, Version.Details.xml | Update SDK, MSBuild SDK and dependency versions |
Comments suppressed due to low confidence (3)
src/libraries/System.Runtime.Numerics/tests/BigInteger/op_rightshift.cs:9
- [nitpick] Type names should use PascalCase according to .NET naming conventions. Consider renaming
op_rightshiftTestBasetoOpRightShiftTestBase.
public abstract class op_rightshiftTestBase
src/libraries/System.Private.CoreLib/src/System/IO/RandomAccess.Unix.cs:172
- The expression
stackalloc Interop.Sys.IOVector[IovStackThreshold].Slice(0, buffersCount)is missing parentheses around the stackalloc, causing a syntax error. It should be written as(stackalloc Interop.Sys.IOVector[IovStackThreshold]).Slice(0, buffersCount)to compile.
new Interop.Sys.IOVector[buffersCount];
src/native/external/zlib-intel/inflate.c:254
- Changing
ret = Z_MEM_ERRORtoreturn Z_MEM_ERRORalters the original control flow and may skip cleanup code that runs after the loop. Verify that early return is intended and does not leak state or skip necessary finalization.
return Z_MEM_ERROR;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming CI passes, LGTM.
use "Merge commit"