-
Couldn't load subscription status.
- Fork 5.2k
[release/8.0-staging] Remove invalid GCPROTECT for duplicate slot
#117030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging] Remove invalid GCPROTECT for duplicate slot
#117030
Conversation
|
Tagging subscribers to this area: @mangod9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. please get a code review. we will take for consideration in 8.0.x
Backport of #100787 to release/8.0-staging
/cc @elinor-fung @AaronRobinsonMSFT @dotnet/interop-contrib
Customer Impact
This is an intermittent issue that can result in a crash when a GC occurs during marshalling of a struct. This was found via tests for 9.0 and reported by an external customer for 8.0.
Regression
dotnet/coreclr#26340
Testing
This issue was hit in GC stress tests. It was fixed in 9.0 and has been working since.
Risk
Low. Fix has been in since 9.0.