Implement EF.MultipleParameters method. #36358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for the new EF.MultipleParameters query method by extending the core query pipeline, expression visitors, and SQL generation, and updates tests to exercise the new parameterization modes.
- Add a
ParameterExpressionModeenum and thread it throughQueryParameterExpression, normalization, funcletization, and SQL translation. - Extend relational and SQL Server nullability and in‐memory processors to handle multiple parameter expansions.
- Update relational, SQL Server, SQLite, and Cosmos tests to parameterize collection tests over
ParameterizedCollectionModeand add newEF.MultipleParameterstests.
Reviewed Changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/EFCore/Query/QueryParameterExpression.cs | Replace boolean flags with ParameterExpressionMode property. |
| src/EFCore/Query/Internal/QueryableMethodNormalizingExpressionVisitor.cs | Normalize EF.MultipleParameters calls into QueryParameterExpression with the new mode. |
| src/EFCore/Query/Internal/ExpressionTreeFuncletizer.cs | Throw appropriate generic error for non-evaluatable EF.MultipleParameters<T>. |
| src/EFCore.Relational/Query/SqlNullabilityProcessor.cs | Handle multiple parameter expansion based on ParameterExpressionMode. |
| src/EFCore.Relational/Query/SqlExpressions/SqlParameterExpression.cs | Replace ShouldBeConstantized with ParameterExpressionMode. |
| src/EFCore.Relational/Query/RelationalSqlTranslatingExpressionVisitor.cs | Apply new mode flags when generating IN and JSON queries. |
| src/EFCore.Relational/Query/Internal/RelationalParameterProcessor.cs | Thread ParameterExpressionMode through parameter processing. |
| src/EFCore/Properties/CoreStrings.resx | Consolidate EF.Constant/EF.Parameter error messages into generic template. |
| test/.../NonSharedPrimitiveCollections* | Convert collection tests to theories over ParameterizedCollectionMode. |
| test/.../NorthwindWhereQuery* | Add EF_MultipleParameters_with_non_evaluatable_argument_throws tests for relational and provider-specific projects. |
Files not reviewed (1)
- src/EFCore/Properties/CoreStrings.Designer.cs: Language not supported
src/EFCore/Query/Internal/QueryableMethodNormalizingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Query/RelationalQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
...Relational.Specification.Tests/Query/NonSharedPrimitiveCollectionsQueryRelationalTestBase.cs
Outdated
Show resolved
Hide resolved
roji
requested changes
Jul 15, 2025
src/EFCore.Relational/Query/RelationalQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Query/RelationalQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore/Query/Internal/QueryableMethodNormalizingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
roji
approved these changes
Jul 15, 2025
src/EFCore.Relational/Infrastructure/RelationalDbContextOptionsBuilder.cs
Outdated
Show resolved
Hide resolved
| /// Which parametrized collection translation mode should be used. | ||
| /// </summary> | ||
| public ParameterizedCollectionMode ParameterizedCollectionMode { get; init; } | ||
| public ParameterTranslationMode ParameterizedCollectionMode { get; init; } |
There was a problem hiding this comment.
Given the new naming, maybe call this CollectionParameterTranslationMode for consistency etc. (also elsewhere)
There was a problem hiding this comment.
UseParameterizedCollectionMode stays?
There was a problem hiding this comment.
I guess in the interest of avoiding another design discussion on the public API at this late hour, let's just keep things as they are - disregard my above comment...
src/EFCore.Relational/Query/RelationalQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Query/SqlExpressions/SqlParameterExpression.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36357.