-
Couldn't load subscription status.
- Fork 3.3k
Closed
Description
As a team, we periodically review changes made to the public API. This issue tracks follow-up items that come out of those reviews for the 10.0 release.
Mar 3
- @roji Obsolete these methods instead of removing them (can be done for other related removed API instead if it's more likely to be used by a provider) (#36449):
public ParameterQueryRootExpression(IAsyncQueryProvider asyncQueryProvider, Type elementType, ParameterExpression parameterExpression)public ParameterQueryRootExpression(Type elementType, ParameterExpression parameterExpression)public virtual ParameterExpression ParameterExpression { [CompilerGeneratedAttribute]get; }
- @roji Consider making
QueryableMethodTranslatingExpressionVisitor.ExecuteUpdateSetternon-nestedprotected- @roji says: looked at this, and ExecuteUpdateSetter is an intermediate type within translation that's only exposed to providers - I think it probably makes sense to keep it where it is... We can re-discuss in design.
- @roji Move the
QueryHelpersmethods toInfrastructure.EnumerableExtensions(#36449) - @roji Consider renaming
QueryParameterExpression.ShouldBeConstantizedandSqlParameterExpression.ShouldBeConstantizedtoShouldBeInlined, also for related names- We recently changed this to accept a ParameterTranslationMode enum (to support multiple parameter in addition to constants/parameter) - I think we're good.
Mar 10
- @roji Mark the removed overload of
RelationalQueryableMethodTranslatingExpressionVisitor.IsValidSelectExpressionForExecuteDeleteas obsolete instead - @roji
Consider removing theoutparameter fromSelectExpression.GetTable- @roji says: Looked at this, it seems like a somewhat reasonable utility... There's also an overload without the out for callers that don't need the index. Was there a specific reason we wanted to get rid of this?
July 14
- @AndriySvyryd Move
HasDefaultFullTextLanguageand related methods from entity type to model - @AndriySvyryd Rename
valueparameter inIsFullTextIndexandSetIsFullTextIndextofullTextIndex, consider making it non-nullable - @AndriySvyryd Add
bool vectorIndextoIsVectorIndex - @AndriySvyryd Remove the class constraint on
ToJson - @AndriySvyryd Rename
GenerateDefaultConstraintNametoGetDefaultDefaultConstraintName - @cincuranet Change EFExtensions.MultipleParameters to return
TSource : IEnumerable(#36358) - @cincuranet Make
ParameterizedCollectionMode.MultipleParametersvalue to 0 (#36358)
July 21
- @roji Rename
functionsinCosmosDbFunctionsExtensions.Rrftoscores(#36449) - @roji Stretch: make the parameters on
CosmosDbFunctionsExtensions.VectorDistanceoptional to reduce the number of overloads (done in #36448)
July 28
- @AndriySvyryd Rename
ContainingTypetoContainingEntryTypeand move it toIRuntimeTypeBase - @AndriySvyryd Add
ComplexCollectionTypePropertyBuilder - @AndriySvyryd Remove
IConventionTypeBaseBuilder.IndexerComplexProperty
July 29
- @roji Rename
CacheSafeParameterFacadetoParametersCacheDecorator - @roji Make
ParametersCacheDecorator.CanCachepubternal - @roji Rename
ParametersCacheDecorator.GetParametersAndDisableSqlCachingtoGetAndDisableCaching - @roji Rename
ParametersCacheDecorator.IsParameterNulltoIsNull - @roji Change the return of
QueryCompilationContext.IgnoredQueryFiltersto a read-only set- @roji says: this actually needs to be mutable, since as we process IgnoreQueryFilters() in the query we add to this set.
- @cincuranet Rename
IRelationalCommandBuilder.Append.redacttosensitive(#36469)