fix: toc grouping regression introduced by #10090 #10700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @yufeih - wondering if you could prioritize merging this in, and possibly making a release soon (though I suppose I could try building docfx from source and running that) - we have a few libraries that we haven't been able to properly update the docs on for a long time now waiting on this fix. |
|
@mikernet were you able to validate this PR fixes the issue on your end? |
|
Hmm, it removed some nesting, but removed a bit too much nesting 😅 The namespaces appear at the top level correctly now, but Constructors/Properties/Methods/Explicit Interface Implementations groupings below the classes are gone. How it shows up:
How it should show up:
|
|
Oversight on my end. Give it another try now. |
|
Magnificent. LGTM :) |
yufeih
approved these changes
Jul 1, 2025
|
Thank you @frarees |
philLeu
pushed a commit
to philLeu/docfx
that referenced
this pull request
Jul 13, 2025
* fix: toc grouping regression introduced by dotnet#10090 * oversight
This was referenced Oct 24, 2025
This was referenced Oct 27, 2025
This was referenced Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10424.