Skip to content

feat: expose type through the toc #10090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 12, 2024
Merged

feat: expose type through the toc #10090

merged 8 commits into from
Jul 12, 2024

Conversation

@frarees
Copy link
Contributor

@frarees frarees commented Jul 8, 2024

See #10089.

@frarees
Copy link
Contributor Author

frarees commented Jul 8, 2024

@dotnet-policy-service agree

@frarees frarees mentioned this pull request Jul 8, 2024
Closed
yufeih
yufeih reviewed Jul 9, 2024
View reviewed changes
@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Jul 9, 2024
@frarees frarees marked this pull request as ready for review July 10, 2024 09:21
@frarees
Copy link
Contributor Author

frarees commented Jul 10, 2024

@yufeih any idea why the tests fail?

I've run them locally (just for .NET8, I cannot get some to work on .NET6 on my machine) and they look fine
image

The GitHub Action is returning with Error: Process completed with exit code 1.

@filzrev
Copy link
Contributor

filzrev commented Jul 11, 2024

The GitHub Action is returning with Error: Process completed with exit code 1.

On GitHub Action CI. TestPublicApiContract test seems failed.

2024-07-10T09:23:06.0375360Z [xUnit.net 00:00:01.74] Docfx.Tests.PublicApiContractTest.TestPublicApiContract [FAIL]

It needs following tasks to resolve CI error.

  1. Run TestPublicApiContract test locally.
  2. Commit updated test\docfx.Tests\Api.verified.cs file.

@filzrev
Copy link
Contributor

filzrev commented Jul 11, 2024

PublicApiContractTest error seems be resolved by latest commit.

But PlantUML tests that use external PlantUML server failed with transient error.
It need to re-run CI.

yufeih
yufeih approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @frarees !

@yufeih yufeih merged commit ec959b5 into dotnet:main Jul 12, 2024
@filzrev filzrev mentioned this pull request Jul 12, 2024
Merged
@frarees frarees mentioned this pull request Jul 15, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Nov 18, 2024
Merged
@filzrev filzrev mentioned this pull request Nov 27, 2024
Closed
frarees added a commit to frarees/docfx that referenced this pull request Jun 4, 2025
@frarees
fix: toc grouping regression introduced by dotnet#10090
f75dba9
yufeih pushed a commit that referenced this pull request Jul 1, 2025
@frarees
fix: toc grouping regression introduced by #10090 (#10700)
dd69466 
* fix: toc grouping regression introduced by #10090

* oversight
philLeu pushed a commit to philLeu/docfx that referenced this pull request Jul 13, 2025
@frarees @philLeu
fix: toc grouping regression introduced by dotnet#10090 (dotnet#10700)
6d5b17d 
* fix: toc grouping regression introduced by dotnet#10090

* oversight
@dependabot dependabot bot mentioned this pull request Jul 28, 2025
Open
@dependabot dependabot bot mentioned this pull request Aug 18, 2025
Closed
@filzrev filzrev mentioned this pull request Sep 19, 2025
Merged
@dependabot dependabot bot mentioned this pull request Oct 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yufeih yufeih yufeih approved these changes

Assignees

No one assigned

Labels

new-feature Makes the pull request to appear in "New Features" section of the next release note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@frarees @filzrev @yufeih