Skip to content

fix: Crashed on startup if djangocms-text was not installed #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 27, 2025
Merged

fix: Crashed on startup if djangocms-text was not installed #266

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c5bd098
bump version
fsbraun Mar 26, 2025
210a540
Merge branch 'master' into chore/release-2-1
fsbraun Mar 26, 2025
515995e
docs: Consistency improvements
fsbraun Mar 26, 2025
3129af8
Fix: djangocms-text-ckeditor compatibility
fsbraun Mar 26, 2025
0c46222
Remove debug statement
fsbraun Mar 27, 2025
2104fc2
Merge branch 'master' into chore/release-2-1
fsbraun Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions djangocms_frontend/component_pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ def find_cms_component_templates() -> list[tuple[str, str]]:

class CMSAutoComponentDiscovery:
default_field_context = {
"djanghocms_text": "djangocms_text.fields.TextFormField",
"djanghocms_text_ckeditor": "djangocms_text_ckeditor.fields.TextFormField",
"djangocms_text": "djangocms_text.fields.HTMLFormField",
"djangocms_text_ckeditor": "djangocms_text_ckeditor.fields.HTMLFormField",
"djangocms_link": "djangocms_link.fields.LinkFormField",
"djangocms_frontend": [
"djangocms_frontend.contrib.image.fields.ImageFormField",
Expand Down Expand Up @@ -141,9 +141,10 @@ def setup():
update_plugin_pool()
components._discovered = True

if text_config := apps.get_app_config("djangocms_text"):
if apps.is_installed("djangocms_text"):
# Hack - update inline editable fields in case djangocms_text is installed
# BEFORE djangocms_frontend in INSTALLED_APPS
text_config = apps.get_app_config("djangocms_text")
if text_config.inline_models:
# Already initialized? Need to initialize again
# to reflect inline fields in of just discovered components
Expand Down