- 
                Notifications
    
You must be signed in to change notification settings  - Fork 31
 
fix: Crashed on startup if djangocms-text was not installed #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          
Reviewer's Guide by SourceryThis pull request fixes a crash on startup that occurred when  Updated class diagram for CMSAutoComponentDiscoveryclassDiagram
  class CMSAutoComponentDiscovery {
    default_field_context
  }
  note for CMSAutoComponentDiscovery.default_field_context "djangocms_text field updated to HTMLFormField"
    File-Level Changes
 Tips and commandsInteracting with Sourcery
 Customizing Your ExperienceAccess your dashboard to: 
 Getting Help
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @fsbraun - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider extracting the 
apps.is_installedcheck into a separate function for better readability. - It might be worth adding a comment explaining why the inline models need to be updated when 
djangocms_textis installed beforedjangocms_frontend. 
Here's what I looked at during the review
- 🟢 General issues: all looks good
 - 🟢 Security: all looks good
 - 🟢 Testing: all looks good
 - 🟢 Complexity: all looks good
 - 🟢 Documentation: all looks good
 
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
          Codecov ReportAttention: Patch coverage is  
 
 Additional details and impacted files@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   88.69%   88.69%           
=======================================
  Files         124      124           
  Lines        3360     3361    +1     
  Branches      283      283           
=======================================
+ Hits         2980     2981    +1     
  Misses        263      263           
  Partials      117      117           ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
Summary by Sourcery
Fix startup crash when djangocms-text is not installed by improving component discovery and field configuration
Bug Fixes:
Enhancements: