fix: fix release workflow error from node 22 #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achou11
approved these changes
Aug 28, 2025
This was referenced Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node LTS has changed to v22, and the optic-release workflow runs in the context of node LTS, not the node version we setup in the previous step.
We are using an older version of better-sqlite3 at the moment, which does not include prebuilds for node v22. It's a dependency of @comapeo/core, which is a dev dep here for tests. better-sqlite3 has a postinstall script that tries to download prebuilds, which is failing on the optic release build command
npm ci.This PR adds
--ignore-scriptsto the optic release build command. This would have an impact if any of the modules we are using in our prepack script rely on install scripts running, but I don't think they do, so I think this is safe to do. Hopefully this will unblock us from running the release workflow for now. We will probably need this change for releasing other packages which have better-sqlite3 as a dep.