Skip to content

Conversation

@varun-edachali-dbx
Copy link
Contributor

@varun-edachali-dbx varun-edachali-dbx commented Jun 30, 2025

What type of PR is this?

  • Bug Fix

Description

This disparity was observed on running test_ssp_passthrough with use_sea as True in #594.

Currently, without explicit conversion of the values of the session_configuration to str, the case of some of the values may not be as expected in the response. Particularly, in test_ssp_passthrough, we get the response as [ansi_mode, true] instead of [ansi_mode, True]. To align with the Thrift implementation (which also does this), we explicitly cast our values to str to ensure the same configuration structure is received by the Databricks deployment regardless of backend choice.

How is this tested?

Related Tickets & Documents

https://docs.google.com/document/d/1Y-eXLhNqqhrMVGnOlG8sdFrCxBTN1GdQvuKG4IfHmo0/edit?usp=sharing

@varun-edachali-dbx varun-edachali-dbx marked this pull request as ready for review July 4, 2025 02:58
@varun-edachali-dbx varun-edachali-dbx merged commit c07beb1 into sea-migration Jul 16, 2025
23 checks passed
@varun-edachali-dbx varun-edachali-dbx mentioned this pull request Jul 22, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants