Skip to content

Conversation

@varun-edachali-dbx
Copy link
Contributor

@varun-edachali-dbx varun-edachali-dbx commented Jun 11, 2025

What type of PR is this?

  • Feature

Description

Complete the Fetch phase of the SEA implementation for INLINE disposition and JSON_ARRAY format. Introduce a new JsonQueue.

Note that this is not yet feature complete, with some known failures in the following domains (for the SEA backend only):

  • retries
  • native, complex params
  • metadata queries

These will be resolved in future PRs.

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually - using the test scripts invoked in examples/experimental/sea_connector_test.py.
  • N/A

The coverage of the key classes by the unit tests are as below:

Module Statements Missing Coverage Notes
utils.py (JsonQueue class) 15 0 100% Completely covered
utils.py (SeaResultSetQueueFactory class) 20 0 100% Completely covered
result_set.py (SeaResultSet class) 155 0 100% Completely covered
conversion.py 43 0 100% Completely covered

Related Tickets & Documents

Design Doc
PECOBLR-484

Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
@databricks databricks deleted a comment from github-actions bot Jul 1, 2025
@databricks databricks deleted a comment from github-actions bot Jul 1, 2025
@databricks databricks deleted a comment from github-actions bot Jul 1, 2025
@databricks databricks deleted a comment from github-actions bot Jul 1, 2025
@databricks databricks deleted a comment from github-actions bot Jul 1, 2025
@github-actions
Copy link

github-actions bot commented Jul 1, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@github-actions
Copy link

github-actions bot commented Jul 1, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: varun-edachali-dbx <[email protected]>
@github-actions
Copy link

github-actions bot commented Jul 2, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Copy link
Contributor

@jayantsing-db jayantsing-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. Rest LGTM.

@github-actions
Copy link

github-actions bot commented Jul 2, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: varun-edachali-dbx <[email protected]>
@github-actions
Copy link

github-actions bot commented Jul 2, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@varun-edachali-dbx varun-edachali-dbx merged commit 70c7dc8 into sea-migration Jul 2, 2025
22 of 23 checks passed
varun-edachali-dbx added a commit that referenced this pull request Jul 22, 2025
@varun-edachali-dbx varun-edachali-dbx mentioned this pull request Jul 23, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants