Skip to content

[swift2objc] Built in declarations should only come from the built in module #2552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[swift2objc] Built in declarations should only come from the built in module #2552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0003f6f
built in only from built in module
liamappelbe Aug 28, 2025
7ee22f7
Merge branch 'main' into swift2objc_builtin
liamappelbe Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions pkgs/swift2objc/lib/src/parser/parsers/declaration_parsers/parse_built_in_declaration.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,13 @@
// BSD-style license that can be found in the LICENSE file.

import '../../../ast/declarations/built_in/built_in_declaration.dart';
import '../../_core/json.dart';
import '../../../config.dart';
import '../../_core/parsed_symbolgraph.dart';
import '../../_core/utils.dart';

BuiltInDeclaration? tryParseBuiltInDeclaration(Json symbolJson) {
final id = parseSymbolId(symbolJson);
BuiltInDeclaration? tryParseBuiltInDeclaration(ParsedSymbol parsedSymbol) {
if (parsedSymbol.source != builtInInputConfig) return null;
final id = parseSymbolId(parsedSymbol.json);
if (!id.startsWith('c:objc(cs)')) return null;
return BuiltInDeclaration(id: id, name: parseSymbolName(symbolJson));
return BuiltInDeclaration(id: id, name: parseSymbolName(parsedSymbol.json));
}
2 changes: 1 addition & 1 deletion pkgs/swift2objc/lib/src/parser/parsers/parse_declarations.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Declaration parseDeclaration(

final symbolJson = parsedSymbol.json;

final builtIn = tryParseBuiltInDeclaration(symbolJson);
final builtIn = tryParseBuiltInDeclaration(parsedSymbol);
if (builtIn != null) {
return parsedSymbol.declaration = builtIn;
}
Expand Down
Loading