Skip to content

Conversation

liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe commented Aug 28, 2025

Restrict tryParseBuiltInDeclaration to symbols that come from the built in Foundation module. There are symbols in other modules that have IDs starting with c:objc(cs), so if we treat them all as built in, then users can't actually generate bindings for them.

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

@liamappelbe liamappelbe changed the title WIP: [swift2objc] built in only from built in module [swift2objc] Built in declarations should only come from the built in module Aug 28, 2025
@liamappelbe liamappelbe marked this pull request as ready for review August 28, 2025 03:32
@coveralls
Copy link

coveralls commented Aug 28, 2025

Coverage Status

coverage: 77.403% (+0.001%) from 77.402%
when pulling 7ee22f7 on swift2objc_builtin
into 99456de on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants