Allow FunctionTypes to work in place of InterfaceType in applicability check #2109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scheglov
approved these changes
Jan 3, 2020
Contributor
scheglov
left a comment
scheglov
left a comment
There was a problem hiding this comment.
I don't understand this code and logic well enough, but OTOH I don't see definitely wrong things.
|
|
||
| @override | ||
| InterfaceType get interfaceType => (type as TypeParameterType).bound; | ||
| InterfaceType get _interfaceType => (type as TypeParameterType).bound; |
Contributor
There was a problem hiding this comment.
The bound of a type parameter is not always InterfaceType.
Contributor
Author
There was a problem hiding this comment.
Yes, this is just all messed up. Added a todo; will fix if it causes a real world crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2101.
For
CallableGenericTypeAliasElementType, use the FunctionType as the instantiated type, and adjust callers so they can use any DartType and not assume InterfaceType.Also refactors to extract potentially applicable extension detection into a mixin to support a future implementation of #2107.