Add --verbose option to cmake-rn
#130
Conversation
|
kraenhansen
force-pushed
the
kh/cmake-rn/verbose
branch
from
932d57f to
5cb8fe8
Compare
kraenhansen
changed the title
cmake-rn--verbose option to cmake-rn
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new --verbose option to cmake‐rn to allow more detailed output during builds, update dependency versions for bufout, and silence Ora spinners when verbose output is enabled.
- Introduces a new verbose option in packages/cmake-rn/src/cli.ts that switches spawn output from buffered to inherit and provides an output prefix.
- Updates bufout dependency versions in package.json files.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/host/package.json | Updated bufout dependency version |
| packages/ferric/package.json | Updated bufout dependency version |
| packages/cmake-rn/src/cli.ts | Added --verbose option; modified spawn calls to conditionally control output and spinner silence |
| packages/cmake-rn/package.json | Updated bufout dependency version |
| // Configure every triplet project | ||
| await oraPromise(Promise.all(tripletContext.map(configureProject)), { | ||
| text: "Configuring projects", | ||
| isSilent: globalContext.verbose, |
There was a problem hiding this comment.
The spinner configuration uses globalContext.verbose while the spawn calls use a locally destructured verbose flag. For consistency and clearer behavior, consider using one source for the verbose flag throughout the file.
Merging this PR will:
--veboseoption to thecmake-rnwhich will use "inherit" instead of output buffering, add a prefix to output when spawning and and silence Ora spinners. I suggest enabling this by default on CI.