Skip to content

Cross platform unit testing #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 23, 2025
Merged

Cross platform unit testing #121

merged 12 commits into from
Jun 23, 2025

Conversation

@kraenhansen
Copy link
Collaborator

@kraenhansen kraenhansen commented Jun 17, 2025 •
edited
Loading

Merging this PR will:

  • Run all tests across MacOS, Windows and Linux.

@kraenhansen kraenhansen self-assigned this Jun 17, 2025
@changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 13cacb8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kraenhansen kraenhansen mentioned this pull request Jun 17, 2025
Closed
@kraenhansen kraenhansen force-pushed the kh/cross-platform-tests branch 4 times, most recently from 0bcd91b to 5967481 Compare June 19, 2025 20:53
@kraenhansen kraenhansen changed the title Cross platform tests Cross platform unit testing Jun 19, 2025
@kraenhansen kraenhansen force-pushed the kh/cross-platform-tests branch from 5967481 to 0d810cd Compare June 19, 2025 21:19
@kraenhansen kraenhansen mentioned this pull request Jun 19, 2025
Merged
@kraenhansen kraenhansen marked this pull request as ready for review June 20, 2025 05:24
@kraenhansen kraenhansen marked this pull request as draft June 20, 2025 05:25
@kraenhansen kraenhansen force-pushed the kh/cross-platform-tests branch from 0d810cd to 2e957ad Compare June 20, 2025 08:37
@kraenhansen kraenhansen force-pushed the kh/cross-platform-tests branch from 2e957ad to 13cacb8 Compare June 22, 2025 22:10
@kraenhansen kraenhansen marked this pull request as ready for review June 23, 2025 18:54
matthargett
matthargett approved these changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@matthargett matthargett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I like separating out the generate and build steps for the weak node API, should help with narrowing and debugging CI and user reported issues!

@kraenhansen kraenhansen merged commit d168ec6 into main Jun 23, 2025
4 checks passed
@kraenhansen kraenhansen deleted the kh/cross-platform-tests branch June 23, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@matthargett matthargett matthargett approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kraenhansen kraenhansen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kraenhansen @matthargett