Skip to content

Conversation

@br14n-sol
Copy link
Owner

@br14n-sol br14n-sol commented Aug 27, 2024

Closes #18
Replaces #19, #20 1

A new option is added:

type?: 'file' | 'directory' | 'file+directory' // by default: 'file'
  • If type is 'file', you can only select files.
  • If type is 'directory', you can only select directories.
  • If type is 'file+directory', you can select both files and directories.

Animation

Other changes:

  • From now on, the backspace key will be used to navigate within directories.

Questions:

  • If only directories are expected to be selected, should the files be hidden? 2
  • If only files are expected to be selected, should the directories be hidden? 2
  • If the directories are hidden, what would navigation be like? 3
    If there are no directories to enter, you could only go backwards in the directory tree, but not forwards.

Footnotes

  1. Thanks to @wenshuishi for suggesting this and making the first implementation.

  2. These questions will be addressed in the future. 2

  3. With the introduction of the ability to filter both files and directories in pr Replace match option with filter #27, the blocking of navigation will not be a priority for the time being.

@br14n-sol br14n-sol added this to the 0.6.0 milestone Oct 22, 2024
The `type` option is added to define the type selection, either `file`, `directory`, or both `file+directory`. By default the value will be `file` following the expected behavior so far.
In addition, from now on the `backspace` key will be used to navigate within directories.
@br14n-sol br14n-sol changed the title [WIP] Adds the possibility to select directories Adds the possibility to select directories Oct 30, 2024
@br14n-sol br14n-sol marked this pull request as ready for review October 30, 2024 18:02
@br14n-sol br14n-sol merged commit 3039a59 into main Oct 30, 2024
@br14n-sol br14n-sol deleted the add-type-selection branch October 30, 2024 18:02
@br14n-sol br14n-sol removed this from the 0.6.0 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

But how to select a directory?

1 participant