Skip to content

Conversation

@wenshuishi
Copy link

Fix this issue: #18

@wenshuishi wenshuishi marked this pull request as draft August 22, 2024 09:10
@wenshuishi wenshuishi marked this pull request as ready for review August 22, 2024 09:10
@br14n-sol
Copy link
Owner

Hi, first of all thanks for contributing 👍

I'm not sure about adding it as a default behavior, so far only file selection has been allowed, so it would result in unexpected behavior for anyone using the package from previous versions.

@br14n-sol
Copy link
Owner

I was thinking of adding it along with a configuration option, something like this:

expected?: 'file' | 'directory' | 'both'

Being by default the value of: 'file'

@br14n-sol
Copy link
Owner

This is just something I thought of just now, if you have a better idea comment it.

@wenshuishi
Copy link
Author

Hi, first of all thanks for contributing 👍

I'm not sure about adding it as a default behavior, so far only file selection has been allowed, so it would result in unexpected behavior for anyone using the package from previous versions.

Thanks for reply, yes, you are right, maybe give users an option is better.

@wenshuishi
Copy link
Author

wenshuishi commented Aug 23, 2024

I was thinking of adding it along with a configuration option, something like this:

expected?: 'file' | 'directory' | 'both'

Being by default the value of: 'file'

Ok, i have submitted another pull request for that:
you decide whether to merge it, or you can implement it yourself, if you have any better ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants