Skip to content

feat: updated the cognito properties based on cloudformation properties #3767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 2, 2025
Merged

feat: updated the cognito properties based on cloudformation properties #3767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3cbacc0
feat: updated the cognito properties based on cloudformation properties
edinstance May 12, 2025
9ba4395
feat: added translator tests for the new properties
edinstance May 12, 2025
0b9ba41
Merge branch 'develop' into update-cognito-properties
mbfreder May 13, 2025
88ae3e3
Merge branch 'develop' into update-cognito-properties
valerena Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions samtranslator/model/cognito.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ class CognitoUserPool(Resource):
"AutoVerifiedAttributes": GeneratedProperty(),
"DeletionProtection": GeneratedProperty(),
"DeviceConfiguration": GeneratedProperty(),
"EmailAuthenticationMessage": GeneratedProperty(),
"EmailAuthenticationSubject": GeneratedProperty(),
"EmailConfiguration": GeneratedProperty(),
"EmailVerificationMessage": GeneratedProperty(),
"EmailVerificationSubject": GeneratedProperty(),
Expand All @@ -28,7 +30,10 @@ class CognitoUserPool(Resource):
"UserPoolAddOns": GeneratedProperty(),
"UserPoolName": GeneratedProperty(),
"UserPoolTags": GeneratedProperty(),
"UserPoolTier": GeneratedProperty(),
"VerificationMessageTemplate": GeneratedProperty(),
"WebAuthnRelyingPartyID": GeneratedProperty(),
"WebAuthnUserVerification": GeneratedProperty(),
}

runtime_attrs = {
Expand Down
11 changes: 11 additions & 0 deletions tests/translator/input/cognito_template_with_new_properties.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
Transform: AWS::Serverless-2016-10-31
Resources:
MyUserPool:
Type: AWS::Cognito::UserPool
Properties:
UserPoolTier: PLUS
UserPoolName: MyUserPool
EmailAuthenticationMessage: Your verification code is {####}
EmailAuthenticationSubject: Your verification code
WebAuthnRelyingPartyID: id
WebAuthnUserVerification: required
15 changes: 15 additions & 0 deletions tests/translator/output/aws-cn/cognito_template_with_new_properties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"Resources": {
"MyUserPool": {
"Properties": {
"EmailAuthenticationMessage": "Your verification code is {####}",
"EmailAuthenticationSubject": "Your verification code",
"UserPoolName": "MyUserPool",
"UserPoolTier": "PLUS",
"WebAuthnRelyingPartyID": "id",
"WebAuthnUserVerification": "required"
},
"Type": "AWS::Cognito::UserPool"
}
}
}
15 changes: 15 additions & 0 deletions tests/translator/output/aws-us-gov/cognito_template_with_new_properties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"Resources": {
"MyUserPool": {
"Properties": {
"EmailAuthenticationMessage": "Your verification code is {####}",
"EmailAuthenticationSubject": "Your verification code",
"UserPoolName": "MyUserPool",
"UserPoolTier": "PLUS",
"WebAuthnRelyingPartyID": "id",
"WebAuthnUserVerification": "required"
},
"Type": "AWS::Cognito::UserPool"
}
}
}
15 changes: 15 additions & 0 deletions tests/translator/output/cognito_template_with_new_properties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"Resources": {
"MyUserPool": {
"Properties": {
"EmailAuthenticationMessage": "Your verification code is {####}",
"EmailAuthenticationSubject": "Your verification code",
"UserPoolName": "MyUserPool",
"UserPoolTier": "PLUS",
"WebAuthnRelyingPartyID": "id",
"WebAuthnUserVerification": "required"
},
"Type": "AWS::Cognito::UserPool"
}
}
}