Skip to content

Conversation

edinstance
Copy link
Contributor

@edinstance edinstance commented May 12, 2025

Issue #3726

Description of changes

Update the CognitoUserPool property types based on the CloudFormation syntax .

Description of how you validated changes

The changes were validated by running the sam transformer on the template in the issue and on another template with all of the new properties. There is also a new transform test for validating this.

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@edinstance edinstance requested a review from a team as a code owner May 12, 2025 23:03
Copy link
Member

@roger-zhangg roger-zhangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roger-zhangg roger-zhangg merged commit 63a53e4 into aws:develop Jun 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants