Skip to content

Conversation

nargokul
Copy link
Collaborator

PR Approval Steps

For Requester

  1. Description
    • Check the PR title and description for clarity. It should describe the changes made and the reason behind them.
    • Ensure that the PR follows the contribution guidelines, if applicable.
  2. Security requirements
  3. Manual review
    1. Click on the Files changed tab to see the code changes. Review the changes thoroughly:
      • Code Quality: Check for coding standards, naming conventions, and readability.
      • Functionality: Ensure that the changes meet the requirements and that all necessary code paths are tested.
      • Security: Check for any security issues or vulnerabilities.
      • Documentation: Confirm that any necessary documentation (code comments, README updates, etc.) has been updated.
  4. Check for Merge Conflicts:
    • Verify if there are any merge conflicts with the base branch. GitHub will usually highlight this. If there are conflicts, you should resolve them.

For Reviewer

  1. Go through For Requester section to double check each item.
  2. Request Changes or Approve the PR:
    1. If the PR is ready to be merged, click Review changes and select Approve.
    2. If changes are required, select Request changes and provide feedback. Be constructive and clear in your feedback.
  3. Merging the PR
    1. Check the Merge Method:
      1. Decide on the appropriate merge method based on your repository's guidelines (e.g., Squash and merge, Rebase and merge, or Merge).
    2. Merge the PR:
      1. Click the Merge pull request button.
      2. Confirm the merge by clicking Confirm merge.

mbnavali and others added 30 commits June 10, 2025 14:58
1. update image tag
2. Remove IAM policies for execution role
3. Rename to hyperpod-inference-operator prefix instead of deploymentoperator prefix
Introduce helm charts for hyperpod inference operator
* Add CRDs and setup for region

* Change annotation for SA

* Remove default region
**Description**
Support jumpstart and custom model endpoints

**Testing Done**
Tested manually, will add unit tests in next few PRs
**Description**

Refactor ModelEndpoint classes to let create happen in separate method instead of constructor

**Testing Done**

Manually tested in demo notebook
Tested manually in demo jupyter notebook
**Description**

**Testing Done**

Unit test passes
Make function classmethod and update unit tests
…as dependencies

feat: add pv and pvc creation as part of helm
Add additional required dependencies for the HyperPod Inference Operator
jam-jee and others added 19 commits July 9, 2025 14:02
* Bring HyperPodManager class util functions

Unit tests pass and verified in notebook

* Update init
… test) (#120)

* baseline inference integration test for CLI and SDK, minor bug fix for inference cli, clear inference sdk notebook output

* update integ test in progress

* update cli code, notebook, integ and unit test to add list_pods and get_logs

* clean up merge header
…ime (#122)

Updated unit tests and verified in notebook
* Update Readme to include Inference and Training

* Update readme command

* Documentation updates

* Doc Updates
#125)

* Update inference and training to only check kubeconfig on the first time

Updated unit tests and verified in notebook

* Remove old unit tests

* Revert "Remove old unit tests"

This reverts commit e728e9864c853635f724e9a377fbe870f0f2e2a4.

* Move observability utils and constants; Rename set_context/get_context
* Changelog updates

* Rebase and update

* Fix
* Update Readme to include Inference and Training

* Update readme command

* Documentation updates

* Doc Updates

* Readme updates

* Fix README.md

* Remove Orchestrator from List Cluster

* Changes to README.md

* Fix the link

* Remove orchestrator from README.md
* use unique basename for test file modules

* fix unit tests

* remove append_uuid test

* fix failing test_invoke tests

---------

Co-authored-by: adishaa <[email protected]>
* Fix get_cluster_context runtime error

* Remove Py38 fromtests
* Fix get_cluster_context runtime error

* Remove Py38 fromtests

* Fix

* Unit test fixes
* baseline inference integration test for CLI and SDK, minor bug fix for inference cli, clear inference sdk notebook output

* update integ test in progress

* update cli code, notebook, integ and unit test to add list_pods and get_logs

* clean up merge header

* inference integ tests all passing in chait's account
* baseline inference integration test for CLI and SDK, minor bug fix for inference cli, clear inference sdk notebook output

* update integ test in progress

* update cli code, notebook, integ and unit test to add list_pods and get_logs

* clean up merge header

* inference integ tests all passing in chait's account

* integ test passing on beta account
* Test PR

* Fix is_kubeconfig_loaded Class attribute bug
@nargokul nargokul requested a review from a team as a code owner July 10, 2025 14:36
# Conflicts:
#	helm_chart/readme.md
#	src/hyperpod_cli/commands/job.py
@@ -2,6 +2,7 @@ name: PR Checks
on:
pull_request_target:
branches:
- "master*"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: may not need master branch here, CI would be running on main

@nargokul nargokul merged commit 95096e8 into main Jul 10, 2025
27 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.