Skip to content

Conversation

haardm
Copy link
Contributor

@haardm haardm commented Oct 11, 2024

…1.0.318.0_1.0.35.0

Release 1.0.318.0_1.0.35.0 includes:

  1. Kubernets node annotations for upto previous 20 faults detected by the Health Monitoring Agent.
  2. Support for detecting KernelDeadlock errors coming from user application task getting hung.

PR Approval Steps

For Requester

  1. Description
    • Check the PR title and description for clarity. It should describe the changes made and the reason behind them.
    • Ensure that the PR follows the contribution guidelines, if applicable.
  2. Security requirements
  3. Manual review
    1. Click on the Files changed tab to see the code changes. Review the changes thoroughly:
      • Code Quality: Check for coding standards, naming conventions, and readability.
      • Functionality: Ensure that the changes meet the requirements and that all necessary code paths are tested.
      • Security: Check for any security issues or vulnerabilities.
      • Documentation: Confirm that any necessary documentation (code comments, README updates, etc.) has been updated.
  4. Check for Merge Conflicts:
    • Verify if there are any merge conflicts with the base branch. GitHub will usually highlight this. If there are conflicts, you should resolve them.

For Reviewer

  1. Go through For Requester section to double check each item.
  2. Request Changes or Approve the PR:
    1. If the PR is ready to be merged, click Review changes and select Approve.
    2. If changes are required, select Request changes and provide feedback. Be constructive and clear in your feedback.
  3. Merging the PR
    1. Check the Merge Method:
      1. Decide on the appropriate merge method based on your repository's guidelines (e.g., Squash and merge, Rebase and merge, or Merge).
    2. Merge the PR:
      1. Click the Merge pull request button.
      2. Confirm the merge by clicking Confirm merge.

…1.0.318.0_1.0.35.0

Release 1.0.318.0_1.0.35.0 includes:
1. Kubernets node annotations for upto previous 20 faults detected by the Health Monitoring Agent.
2. Support for detecting KernelDeadlock errors coming from user application task getting hung.
@haardm haardm marked this pull request as draft October 11, 2024 20:38
@adheshgarg adheshgarg marked this pull request as ready for review October 11, 2024 20:39
Copy link
Contributor

@adheshgarg adheshgarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adheshgarg adheshgarg merged commit 69b002b into aws:main Oct 11, 2024
1 of 2 checks passed
@haardm haardm deleted the haardm-release-hma-1.0.318.0_1.0.35.0 branch March 4, 2025 23:39
nargokul pushed a commit that referenced this pull request Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants