Skip to content

Conversation

@gosar
Copy link
Contributor

@gosar gosar commented Sep 28, 2023

Motivation and Context

This is to address an issue from an earlier PR #4495 (comment). The change was made earlier to account for useSraAuth=false, but affects an edge-case for useSraAuth=true.

Modifications

Added the removed check back, but made it conditional on useSraAuth=true.

Testing

I think a functional test could be added to codegen-generated-classes-test to show the issue and prevent it from reoccurring in future. Might have to come back to adding test later, based on prioritization.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@gosar gosar requested a review from a team as a code owner September 28, 2023 23:06
@gosar gosar mentioned this pull request Sep 28, 2023
12 tasks
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 474 Code Smells

84.3% 84.3% Coverage
3.9% 3.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@gosar gosar merged commit 513f034 into feature/master/sra-identity-auth Sep 29, 2023
@gosar gosar deleted the gosar/sra-ia-EndpointResolverInterceptor branch September 29, 2023 00:46
alextwoods pushed a commit that referenced this pull request Nov 19, 2025
…c8d2c7d65

Pull request: release <- staging/98198af2-4dda-4967-85e1-adac8d2c7d65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants