Make s3control work with preSRA codegen #4495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
gosar
force-pushed
the
gosar/sra-ia-s3control-preSRA
branch
from
db74c34 to
6228139
Compare
gosar
changed the base branch from
feature/master/sra-identity-auth
to
gosar/sra-ia-SraIdentityResolutionTest
sugmanue
approved these changes
Sep 28, 2023
gosar
changed the base branch from
gosar/sra-ia-SraIdentityResolutionTest
to
feature/master/sra-identity-auth
|
SonarCloud Quality Gate failed.
|
gosar
commented
Sep 28, 2023
| private <T extends Identity> SelectedAuthScheme<T> authSchemeWithEndpointSignerProperties( | ||
| List<EndpointAuthScheme> endpointAuthSchemes, SelectedAuthScheme<T> selectedAuthScheme) { | ||
| for (EndpointAuthScheme endpointAuthScheme : endpointAuthSchemes) { | ||
| if (!endpointAuthScheme.schemeId().equals(selectedAuthScheme.authSchemeOption().schemeId())) { |
Contributor
Author
There was a problem hiding this comment.
Thanks @millems for highlighting that not checking this could be an issue for useSraAuth=true client, in a case for example where SelectedAuthScheme=sigv4a, but endpointAuthSchemes=["sigv4","sigv4a"] and the shared signer properties like disableDoubleEncoding have different values from endpoint rules. Without this check, the value from sigv4 EndpointAuthScheme will get used, even though it should use from sigv4a EndpointAuthScheme.
Will address this is separate PR.
12 tasks
aws-sdk-java-automation
added a commit
that referenced
this pull request
Nov 14, 2025
…1304dfad7 Pull request: release <- staging/d73ba50f-8835-45de-888c-6b41304dfad7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is follow up from #4491, where I forced s3control to useSraAuth=true path since tests were failing with useSraAuth=false. Fixing it here.
Modifications
With #4396 since we could have a dummy auth scheme (which would definitely be true for useSraAuth=false), we add the SignerProperties to the SelectedAuthScheme, irrespective of the schemeId. For useSraAuth path, where old Signer is used, this effectively adds the ExecutionAttributes that old Signer needs because of #4396.
Testing
./mvnw clean install -pl :codegen,:s3controlpasses locally.Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License