fix(dialog): set aria-labelledby based on the md-dialog-title #5178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
approved these changes
Jun 17, 2017
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
In a follow-up we should add ariaLabel and ariaLabelledBy to the dialog config for cases when you don't use md-dialog-title
| dialogRef: MdDialogRef<T>, | ||
| dialogContainer: MdDialogContainer): DialogInjector { | ||
|
|
||
| let userInjector = config && config.viewContainerRef && config.viewContainerRef.injector; |
* [Based on the accessibility guidelines](https://www.w3.org/TR/wai-aria-practices-1.1/#dialog_modal), these changes add the `aria-labelledby` to dialog that use `md-dialog-title`, which causes the screen reader to read out the title. E.g. before NVDA would read out "Dialog", but now it reads out "Neptune dialog". * Adds the MdDialogContainer instance to the dialog injector. * Slight refactor of the dialog injector to make a little easier to add more tokens.
crisbeto
force-pushed
the
dialog-aria-labelledby
branch
from
883dc2e to
b3e0ea0
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aria-labelledbyto dialogs that usemd-dialog-title, which causes the screen reader to read out the title. E.g. before NVDA would read out "Dialog", but now it reads out "Neptune dialog".