-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(dialog): add ariaLabelledBy config option #14943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dialog): add ariaLabelledBy config option #14943
Conversation
crisbeto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one nit.
ba0b96e to
01bc7ae
Compare
this change adds the ability to set the `aria-labelledby` of a dialog. user can customize the `aria-labelledby` without mat-dialog-title. no breaking changes. existing functionality is preserved without setting the ariaLabelledBy config option.
01bc7ae to
557ef14
Compare
|
@crisbeto fixed your comment. Anything I need to fix to get the branch-manager passing? I have already rebased. |
|
Nope, that failing CI check will be sorted out by the caretaker. |
jelbourn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |

This change adds the ability to manually set the
aria-labelledbyattribute of aMatDialog.Users can set the
aria-labelledbywithout themat-dialog-titledirective. Users can provide multiple id's.It is described as an attribute of
MatDialogConfigin the Dialog Accessibility Documentation, but is not implemented. This was also mentioned as a follow up to #5176 (comment).No breaking changes. Existing functionality is preserved without setting the
ariaLabelledByconfig attribute.