Skip to content

fix(input,select): align colors with spec #5155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2017
Merged

fix(input,select): align colors with spec #5155

merged 1 commit into from
Jul 21, 2017

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 15, 2017

Fixes #5114.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 15, 2017
@crisbeto crisbeto mentioned this pull request Jun 15, 2017
Closed
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jun 21, 2017
@jelbourn jelbourn added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jun 22, 2017
@jelbourn
Copy link
Member

jelbourn commented Jun 22, 2017

Caretaker note: screenshot diffs need approval

@crisbeto
fix(input,select): align colors with spec
0ebe7f7 
* Aligns the colors in the select and input [themes based on the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states).
* Includes the changes from angular#4883 since the two PRs are closely connected.

Fixes angular#5114.
@crisbeto crisbeto force-pushed the 5114/input-color-specs branch from b48825f to 0ebe7f7 Compare July 15, 2017 07:40
@kara kara removed the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jul 21, 2017
@kara kara merged commit 266f237 into angular:master Jul 21, 2017
@mmalerba mmalerba mentioned this pull request Sep 6, 2017
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Input label, hint and placeholder colors don't follow material design spec

5 participants

@crisbeto @jelbourn @mmalerba @kara @googlebot